Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConsumerStatus changed to simple type ConsumerNotification #151

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

aricart
Copy link
Member

@aricart aricart commented Nov 20, 2024

change(jetstream): ConsumerStatus and ConsumerDebugStatus are now… replaced by ConsumerNotification which is an alias for specific types for the the different notifications. All discriminated by their type field. This simplifies down-stream consumption and provides a richer API for accessing the data in the notification.

… replaced by `ConsumerNotificationType` which is an alias for specific types for the the different notifications. All discriminated by their `type` field. This simplifies down-stream consumption and provides a richer API for accessing the data in the notification.

Signed-off-by: Alberto Ricart <alberto@synadia.com>
@aricart aricart force-pushed the consumer-notifications branch from e6a6936 to 0619fdc Compare November 20, 2024 22:12
Copy link

@scottf scottf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aricart aricart merged commit d4643a6 into main Nov 20, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants