From 2498525a6fb693f7d79f01fbe69a6f6f6543ba34 Mon Sep 17 00:00:00 2001
From: Dimitar Dimitrov <dimitrov2k@gmail.com>
Date: Mon, 31 Jul 2023 17:04:47 +0300
Subject: [PATCH] Add `#[must_use]` to `Publish` and refactor message `ack`
 calls

---
 async-nats/src/client.rs            | 3 ++-
 async-nats/src/jetstream/message.rs | 6 ++----
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/async-nats/src/client.rs b/async-nats/src/client.rs
index b1b414321..98018f19b 100644
--- a/async-nats/src/client.rs
+++ b/async-nats/src/client.rs
@@ -44,6 +44,7 @@ impl From<tokio::sync::mpsc::error::SendError<Command>> for PublishError {
     }
 }
 
+#[must_use]
 pub struct Publish {
     sender: mpsc::Sender<Command>,
     subject: String,
@@ -79,7 +80,7 @@ impl IntoFuture for Publish {
     type IntoFuture = Pin<Box<dyn Future<Output = Result<(), PublishError>> + Send>>;
 
     fn into_future(self) -> Self::IntoFuture {
-        let sender = self.sender.clone();
+        let sender = self.sender;
         let subject = self.subject;
         let payload = self.payload;
         let respond = self.respond;
diff --git a/async-nats/src/jetstream/message.rs b/async-nats/src/jetstream/message.rs
index 40a8fe901..a1530a457 100644
--- a/async-nats/src/jetstream/message.rs
+++ b/async-nats/src/jetstream/message.rs
@@ -89,9 +89,8 @@ impl Message {
             self.context
                 .client
                 .publish(reply.to_string(), "".into())
-                .into_future()
-                .map_err(Error::from)
                 .await
+                .map_err(Error::from)
         } else {
             Err(Box::new(std::io::Error::new(
                 std::io::ErrorKind::Other,
@@ -132,9 +131,8 @@ impl Message {
             self.context
                 .client
                 .publish(reply.to_string(), kind.into())
-                .into_future()
-                .map_err(Error::from)
                 .await
+                .map_err(Error::from)
         } else {
             Err(Box::new(std::io::Error::new(
                 std::io::ErrorKind::Other,