From bfd34f9b54301e15a8d5844f6f1919727db0c1bc Mon Sep 17 00:00:00 2001 From: Dimitar Dimitrov Date: Mon, 31 Jul 2023 17:04:47 +0300 Subject: [PATCH] Add `#[must_use]` to `Publish` and refactor message `ack` calls --- async-nats/src/client.rs | 3 ++- async-nats/src/jetstream/message.rs | 6 ++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/async-nats/src/client.rs b/async-nats/src/client.rs index 6634fcff6..a21512f72 100644 --- a/async-nats/src/client.rs +++ b/async-nats/src/client.rs @@ -45,6 +45,7 @@ impl From> for PublishError { } } +#[must_use] pub struct Publish { sender: mpsc::Sender, subject: String, @@ -80,7 +81,7 @@ impl IntoFuture for Publish { type IntoFuture = Pin> + Send>>; fn into_future(self) -> Self::IntoFuture { - let sender = self.sender.clone(); + let sender = self.sender; let subject = self.subject; let payload = self.payload; let respond = self.respond; diff --git a/async-nats/src/jetstream/message.rs b/async-nats/src/jetstream/message.rs index 40a8fe901..a1530a457 100644 --- a/async-nats/src/jetstream/message.rs +++ b/async-nats/src/jetstream/message.rs @@ -89,9 +89,8 @@ impl Message { self.context .client .publish(reply.to_string(), "".into()) - .into_future() - .map_err(Error::from) .await + .map_err(Error::from) } else { Err(Box::new(std::io::Error::new( std::io::ErrorKind::Other, @@ -132,9 +131,8 @@ impl Message { self.context .client .publish(reply.to_string(), kind.into()) - .into_future() - .map_err(Error::from) .await + .map_err(Error::from) } else { Err(Box::new(std::io::Error::new( std::io::ErrorKind::Other,