Fix clippy lints

Author: cjdsellers

RELEASES.md

@@ -46,6 +46,7 @@ None
 - Improved Cython-Rust indicator parity for `ExponentialMovingAverage` (EMA) (#2642), thanks @nicolad
 - Improved Cython-Rust indicator parity for `HullMovingAverage` (HMA) (#2648), thanks @nicolad
 - Improved Cython-Rust indicator parity for `LinearRegression` (#2651), thanks @nicolad
+- Improved Cython-Rust indicator parity for `WilderMovingAverage` (RMA) (#2653), thanks @nicolad
 - Improved zero size trade logging for Binance Futures (#2588), thanks @bartolootrit
 - Improved error handling on API key authentication errors for Polymarket
 - Improved exception on deserializing order from cache database
@@ -71,6 +72,7 @@ None
 - Fixed position snapshot cache access for `ExecutionEngine`
 - Fixed authentication for Redis when password provided with no username
 - Fixed various numpy and pandas FutureWarning(s)
+- Fixed message bus subscription matching logic in Rust (#2646), thanks @twitu
 - Fixed trailing stop market fill behavior when top-level exhausted to align with market orders (#2540), thanks for reporting @stastnypremysl
 - Fixed stop limit fill behavior on initial trigger where the limit order was continuing to fill as a taker beyond available liquidity, thanks for reporting @hope2see
 - Fixed modifying and updating trailing stop orders (#2619), thanks @hope2see

crates/backtest/src/engine.rs

@@ -81,7 +81,7 @@ impl BacktestEngine {
     ///
     /// # Errors
     ///
-    /// Returns an error if the core NautilusKernel fails to initialize.
+    /// Returns an error if the core `NautilusKernel` fails to initialize.
     pub fn new(config: BacktestEngineConfig) -> anyhow::Result<Self> {
         let kernel = NautilusKernel::new(Ustr::from("BacktestEngine"), config.kernel.clone())?;
 

crates/common/src/msgbus/core.rs

@@ -1,3 +1,18 @@
+// -------------------------------------------------------------------------------------------------
+//  Copyright (C) 2015-2025 2Nautech Systems Pty Ltd. All rights reserved.
+//  https://nautechsystems.io
+//
+//  Licensed under the GNU Lesser General Public License Version 3.0 (the "License");
+//  You may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at https://www.gnu.org/licenses/lgpl-3.0.en.html
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+// -------------------------------------------------------------------------------------------------
+
 use std::{
     cell::RefCell,
     collections::HashMap,
@@ -90,7 +105,6 @@ impl Display for Topic {
 /// This is an internal class intended to be used by the message bus to organize
 /// topics and their subscribers.
 ///
-
 #[derive(Clone, Debug)]
 pub struct Subscription {
     /// The shareable message handler for the subscription.

crates/common/src/msgbus/matching.rs

@@ -1,3 +1,18 @@
+// -------------------------------------------------------------------------------------------------
+//  Copyright (C) 2015-2025 2Nautech Systems Pty Ltd. All rights reserved.
+//  https://nautechsystems.io
+//
+//  Licensed under the GNU Lesser General Public License Version 3.0 (the "License");
+//  You may not use this file except in compliance with the License.
+//  You may obtain a copy of the License at https://www.gnu.org/licenses/lgpl-3.0.en.html
+//
+//  Unless required by applicable law or agreed to in writing, software
+//  distributed under the License is distributed on an "AS IS" BASIS,
+//  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+//  See the License for the specific language governing permissions and
+//  limitations under the License.
+// -------------------------------------------------------------------------------------------------
+
 use ustr::Ustr;
 
 use super::core::{Pattern, Topic};

crates/indicators/src/average/lr.rs

@@ -93,7 +93,7 @@ impl LinearRegression {
 
         let n = period as f64;
         let x_sum = 0.5 * n * (n + 1.0);
-        let x_mul_sum = x_sum * (2.0 * n + 1.0) / 3.0;
+        let x_mul_sum = x_sum * 2.0f64.mul_add(n, 1.0) / 3.0;
         let divisor = n.mul_add(x_mul_sum, -(x_sum * x_sum));
 
         Self {
@@ -266,7 +266,7 @@ mod tests {
     fn test_inputs_len_never_exceeds_period() {
         let mut lr = LinearRegression::new(3);
         for i in 0..10 {
-            lr.update_raw(i as f64);
+            lr.update_raw(f64::from(i));
         }
         assert_eq!(lr.inputs.len(), lr.period);
     }
@@ -275,7 +275,7 @@ mod tests {
     fn test_oldest_element_evicted() {
         let mut lr = LinearRegression::new(4);
         for v in 1..=5 {
-            lr.update_raw(v as f64);
+            lr.update_raw(f64::from(v));
         }
         assert!(!lr.inputs.contains(&1.0));
         assert_eq!(lr.inputs.front(), Some(&2.0));
@@ -285,7 +285,7 @@ mod tests {
     fn test_recent_elements_preserved() {
         let mut lr = LinearRegression::new(5);
         for v in 0..5 {
-            lr.update_raw(v as f64);
+            lr.update_raw(f64::from(v));
         }
         lr.update_raw(99.0);
         let expected = vec![1.0, 2.0, 3.0, 4.0, 99.0];
@@ -420,7 +420,7 @@ mod tests {
 
         let n = period as f64;
         let expected_x_sum = 0.5 * n * (n + 1.0);
-        let expected_x_mul_sum = expected_x_sum * (2.0 * n + 1.0) / 3.0;
+        let expected_x_mul_sum = expected_x_sum * 2.0f64.mul_add(n, 1.0) / 3.0;
         let expected_divisor = n.mul_add(expected_x_mul_sum, -(expected_x_sum * expected_x_sum));
 
         assert!((lr.x_sum - expected_x_sum).abs() < 1e-12, "x_sum mismatch");
@@ -441,7 +441,7 @@ mod tests {
         let (x_sum, x_mul_sum, divisor) = (lr.x_sum, lr.x_mul_sum, lr.divisor);
 
         for v in 0..20 {
-            lr.update_raw(v as f64);
+            lr.update_raw(f64::from(v));
         }
 
         assert_eq!(lr.x_sum, x_sum, "x_sum must remain unchanged after updates");
@@ -462,7 +462,7 @@ mod tests {
         let (x_sum, x_mul_sum, divisor) = (lr.x_sum, lr.x_mul_sum, lr.divisor);
 
         for v in 0..8 {
-            lr.update_raw(v as f64);
+            lr.update_raw(f64::from(v));
         }
         lr.reset();
 

crates/indicators/src/average/rma.rs

@@ -259,7 +259,7 @@ mod tests {
         let mut rma = WilderMovingAverage::new(10, None);
 
         for price in 1_u32..=10 {
-            rma.update_raw(price as f64);
+            rma.update_raw(f64::from(price));
         }
 
         assert!(rma.initialized());
@@ -291,7 +291,7 @@ mod tests {
         let mut rma = WilderMovingAverage::new(1_000, None);
 
         for p in 1_u32..=999 {
-            rma.update_raw(p as f64);
+            rma.update_raw(f64::from(p));
         }
 
         assert_eq!(rma.count(), 999);