Add and standardize Debug impls

Author: cjdsellers

crates/backtest/src/exchange.rs

@@ -22,6 +22,7 @@
 use std::{
     cell::RefCell,
     collections::{BinaryHeap, HashMap, VecDeque},
+    fmt::Debug,
     rc::Rc,
 };
 
@@ -121,7 +122,7 @@ pub struct SimulatedExchange {
     use_message_queue: bool,
 }
 
-impl std::fmt::Debug for SimulatedExchange {
+impl Debug for SimulatedExchange {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         f.debug_struct(stringify!(SimulatedExchange))
             .field("id", &self.id)

crates/common/src/actor/data_actor.rs

@@ -2155,15 +2155,15 @@ fn log_error(e: &anyhow::Error) {
 
 fn log_not_running<T>(msg: &T)
 where
-    T: std::fmt::Debug,
+    T: Debug,
 {
     // TODO: Potentially temporary for development? drop level at some stage
     log::warn!("Received message when not running - skipping {msg:?}");
 }
 
 fn log_received<T>(msg: &T)
 where
-    T: std::fmt::Debug,
+    T: Debug,
 {
     log::debug!("{RECV} {msg:?}");
 }

crates/common/src/enums.rs

@@ -15,8 +15,6 @@
 
 //! Enumerations for common components.
 
-use std::fmt::Debug;
-
 use log::Level;
 use serde::{Deserialize, Serialize};
 use strum::{Display, EnumIter, EnumString, FromRepr};

crates/common/src/signal.rs

@@ -15,8 +15,6 @@
 
 //! A user signal type.
 
-use std::fmt::Debug;
-
 use nautilus_core::UnixNanos;
 use serde::{Deserialize, Serialize};
 use ustr::Ustr;

crates/network/src/http.rs

@@ -189,7 +189,7 @@ impl From<String> for HttpClientError {
 /// support for rate limiting, timeouts, and custom headers. The client is
 /// built on top of `reqwest` and can be used for both synchronous and
 /// asynchronous HTTP requests.
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 #[cfg_attr(
     feature = "python",
     pyo3::pyclass(module = "nautilus_trader.core.nautilus_pyo3.network")

crates/network/src/lib.rs

@@ -30,6 +30,7 @@
 #![warn(rustc::all)]
 #![deny(unsafe_code)]
 #![deny(nonstandard_style)]
+#![deny(missing_debug_implementations)]
 #![deny(clippy::missing_errors_doc)]
 #![deny(clippy::missing_panics_doc)]
 #![deny(rustdoc::broken_intra_doc_links)]

crates/network/src/ratelimiter/mod.rs

@@ -22,6 +22,7 @@ mod nanos;
 pub mod quota;
 
 use std::{
+    fmt::Debug,
     hash::Hash,
     num::NonZeroU64,
     sync::atomic::{AtomicU64, Ordering},
@@ -47,7 +48,7 @@ use self::{
 ///
 /// Internally, the number tracked here is the theoretical arrival time (a GCRA term) in number of
 /// nanoseconds since the rate limiter was created.
-#[derive(Default)]
+#[derive(Debug, Default)]
 pub struct InMemoryState(AtomicU64);
 
 impl InMemoryState {
@@ -146,6 +147,16 @@ where
     start: C::Instant,
 }
 
+impl<K, C> Debug for RateLimiter<K, C>
+where
+    K: Debug,
+    C: Clock,
+{
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct(stringify!(RateLimiter)).finish()
+    }
+}
+
 impl<K> RateLimiter<K, MonotonicClock>
 where
     K: Eq + Hash,

crates/network/src/socket.rs

@@ -29,6 +29,7 @@
 //! - Controller task manages lifecycle
 
 use std::{
+    fmt::Debug,
     path::Path,
     sync::{
         Arc,
@@ -537,6 +538,12 @@ pub struct SocketClient {
     pub writer_tx: tokio::sync::mpsc::UnboundedSender<WriterCommand>,
 }
 
+impl Debug for SocketClient {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct(stringify!(SocketClient)).finish()
+    }
+}
+
 impl SocketClient {
     /// Connect to the server.
     ///

crates/network/src/websocket.rs

@@ -29,6 +29,7 @@
 //! - Controller task manages lifecycle
 
 use std::{
+    fmt::Debug,
     sync::{
         Arc,
         atomic::{AtomicU8, Ordering},
@@ -588,6 +589,12 @@ pub struct WebSocketClient {
     pub(crate) rate_limiter: Arc<RateLimiter<String, MonotonicClock>>,
 }
 
+impl Debug for WebSocketClient {
+    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
+        f.debug_struct(stringify!(WebSocketClient)).finish()
+    }
+}
+
 impl WebSocketClient {
     /// Creates a websocket client that returns a stream for reading messages.
     ///