Fix clippy lints

Author: cjdsellers

RELEASES.md

@@ -23,6 +23,7 @@ None
 - Improved validations for `StopLimitOrder` in Rust (#2593), thanks @nicolad
 - Improved validations for `StopMarketOrder` in Rust (#2596), thanks @nicolad
 - Improved validations for `TrailingStopMarketOrder` in Rust (#2607), thanks @nicolad
+- Improved orders initialize and display tests in Rust (#2617), thanks @nicolad
 - Improved zero size trade logging for Binance Futures (#2588), thanks @bartolootrit
 - Implemented remaining Display for orders in Rust (#2614), thanks @nicolad
 - Refined `BacktestDataIterator` correctness (#2591), thanks @faysou

crates/data/src/engine/mod.rs

@@ -394,6 +394,7 @@ impl DataEngine {
         self.default_client.as_mut()
     }
 
+    #[must_use]
     pub fn get_clients(&self) -> Vec<&DataClientAdapter> {
         let (default_opt, clients_map) = (&self.default_client, &self.clients);
 

crates/data/tests/client.rs

@@ -523,7 +523,7 @@ fn test_bars_subscription(
     let bar_type: BarType = "AUDUSD.SIM-1-MINUTE-LAST-INTERNAL".into();
 
     let sub = SubscribeCommand::Bars(SubscribeBars::new(
-        bar_type.clone(),
+        bar_type,
         Some(client_id),
         Some(venue),
         UUID4::new(),
@@ -539,7 +539,7 @@ fn test_bars_subscription(
     assert_eq!(adapter.subscriptions_bars.len(), 1);
 
     let unsub = UnsubscribeCommand::Bars(UnsubscribeBars::new(
-        bar_type.clone(),
+        bar_type,
         Some(client_id),
         Some(venue),
         UUID4::new(),
@@ -1100,7 +1100,7 @@ fn test_bars_unsubscribe_noop(
     let mut adapter = DataClientAdapter::new(client_id, Some(venue), false, false, client);
     let bar_type: BarType = "AUDUSD.SIM-1-MINUTE-LAST-INTERNAL".into();
     let unsub = UnsubscribeCommand::Bars(UnsubscribeBars::new(
-        bar_type.clone(),
+        bar_type,
         Some(client_id),
         Some(venue),
         UUID4::new(),
@@ -1122,7 +1122,7 @@ fn test_bars_unsubscribe_idempotent(
     let mut adapter = DataClientAdapter::new(client_id, Some(venue), false, false, client);
     let bar_type: BarType = "AUDUSD.SIM-1-MINUTE-LAST-INTERNAL".into();
     let sub = SubscribeCommand::Bars(SubscribeBars::new(
-        bar_type.clone(),
+        bar_type,
         Some(client_id),
         Some(venue),
         UUID4::new(),
@@ -1132,7 +1132,7 @@ fn test_bars_unsubscribe_idempotent(
     ));
     adapter.execute_subscribe(&sub);
     let unsub = UnsubscribeCommand::Bars(UnsubscribeBars::new(
-        bar_type.clone(),
+        bar_type,
         Some(client_id),
         Some(venue),
         UUID4::new(),
@@ -1379,7 +1379,7 @@ fn test_request_data(
     let data_type = DataType::new("ReqType", None);
     let req = RequestData {
         client_id,
-        data_type: data_type.clone(),
+        data_type: data_type,
         request_id: UUID4::new(),
         ts_init: UnixNanos::default(),
         params: None,

crates/data/tests/common/mocks.rs

@@ -19,7 +19,6 @@
 
 // Under development
 #![allow(dead_code)]
-#![allow(unused_variables)]
 
 use std::{cell::RefCell, rc::Rc};
 
@@ -43,11 +42,11 @@ use nautilus_model::identifiers::{ClientId, Venue};
 
 /// A mock implementation of [`DataClient`] for testing, with optional generic recorder.
 pub struct MockDataClient {
-    clock: Rc<RefCell<dyn Clock>>,
-    cache: Rc<RefCell<Cache>>,
     pub client_id: ClientId,
     pub venue: Option<Venue>,
     pub recorder: Option<Rc<RefCell<Vec<DataCommand>>>>,
+    clock: Rc<RefCell<dyn Clock>>,
+    cache: Rc<RefCell<Cache>>,
 }
 
 impl MockDataClient {
@@ -68,7 +67,7 @@ impl MockDataClient {
         }
     }
 
-    /// Creates a new `MockDataClient` that records all DataCommands into the given recorder.
+    /// Creates a new [`MockDataClient`] that records all `DataCommands` into the given recorder.
     #[must_use]
     pub fn new_with_recorder(
         clock: Rc<RefCell<dyn Clock>>,

crates/data/tests/engine.rs

@@ -1151,13 +1151,13 @@ fn test_request_data(
         ts_init: UnixNanos::default(),
         params: None,
     };
-    let cmd = DataCommand::Request(RequestCommand::Data(req.clone()));
+    let cmd = DataCommand::Request(RequestCommand::Data(req));
     send_request_cmd(
         clock,
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );
@@ -1190,7 +1190,7 @@ fn test_request_instrument(
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );
@@ -1222,7 +1222,7 @@ fn test_request_instruments(
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );
@@ -1254,7 +1254,7 @@ fn test_request_book_snapshot(
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );
@@ -1288,7 +1288,7 @@ fn test_request_quotes(
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );
@@ -1322,7 +1322,7 @@ fn test_request_trades(
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );
@@ -1355,7 +1355,7 @@ fn test_request_bars(
         cache,
         client_id,
         venue,
-        &mut *eng,
+        &mut eng,
         cmd.clone(),
         &recorder,
     );