Fix clippy lints

Author: cjdsellers

clippy.toml

@@ -1,3 +1,4 @@
 cognitive-complexity-threshold = 10
 allow-expect-in-tests = true
 allow-unwrap-in-tests = true
+doc-valid-idents = ["PnL", "PnLs", ".."]

crates/analysis/src/analyzer.rs

@@ -198,7 +198,6 @@ impl PortfolioAnalyzer {
     /// # Errors
     ///
     /// Returns an error if:
-    ///
     /// - No currency is specified in a multi-currency portfolio.
     /// - The specified currency is not found in account balances.
     /// - The unrealized PnL currency does not match the specified currency.
@@ -241,7 +240,6 @@ impl PortfolioAnalyzer {
     /// # Errors
     ///
     /// Returns an error if:
-    ///
     /// - No currency is specified in a multi-currency portfolio.
     /// - The specified currency is not found in account balances.
     /// - The unrealized PnL currency does not match the specified currency.

crates/backtest/src/engine.rs

@@ -196,7 +196,6 @@ impl BacktestEngine {
     /// # Errors
     ///
     /// Returns an error if:
-    ///
     /// - The instrument's associated venue has not been added via `add_venue`.
     /// - Attempting to add a `CurrencyPair` instrument for a single-currency CASH account.
     ///

crates/backtest/src/exchange.rs

@@ -137,7 +137,6 @@ impl SimulatedExchange {
     /// # Errors
     ///
     /// Returns an error if:
-    ///
     /// - `starting_balances` is empty.
     /// - `base_currency` is `Some` but `starting_balances` contains multiple currencies.
     #[allow(clippy::too_many_arguments)]

crates/core/src/datetime.rs

@@ -46,6 +46,7 @@ pub const WEEKDAYS: [Weekday; 5] = [
 /// Casting f64 to u64 by truncating the fractional part is intentional for unit conversion,
 /// which may lose precision and drop negative values after clamping.
 #[allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
+#[must_use]
 pub fn secs_to_nanos(secs: f64) -> u64 {
     let nanos = secs * NANOSECONDS_IN_SECOND as f64;
     nanos.max(0.0).trunc() as u64
@@ -56,6 +57,7 @@ pub fn secs_to_nanos(secs: f64) -> u64 {
 /// Casting f64 to u64 by truncating the fractional part is intentional for unit conversion,
 /// which may lose precision and drop negative values after clamping.
 #[allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
+#[must_use]
 pub fn secs_to_millis(secs: f64) -> u64 {
     let millis = secs * MILLISECONDS_IN_SECOND as f64;
     millis.max(0.0).trunc() as u64
@@ -66,6 +68,7 @@ pub fn secs_to_millis(secs: f64) -> u64 {
 /// Casting f64 to u64 by truncating the fractional part is intentional for unit conversion,
 /// which may lose precision and drop negative values after clamping.
 #[allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
+#[must_use]
 pub fn millis_to_nanos(millis: f64) -> u64 {
     let nanos = millis * NANOSECONDS_IN_MILLISECOND as f64;
     nanos.max(0.0).trunc() as u64
@@ -76,6 +79,7 @@ pub fn millis_to_nanos(millis: f64) -> u64 {
 /// Casting f64 to u64 by truncating the fractional part is intentional for unit conversion,
 /// which may lose precision and drop negative values after clamping.
 #[allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
+#[must_use]
 pub fn micros_to_nanos(micros: f64) -> u64 {
     let nanos = micros * NANOSECONDS_IN_MICROSECOND as f64;
     nanos.max(0.0).trunc() as u64
@@ -86,18 +90,21 @@ pub fn micros_to_nanos(micros: f64) -> u64 {
 /// Casting u64 to f64 may lose precision for large values,
 /// but is acceptable when computing fractional seconds.
 #[allow(clippy::cast_precision_loss)]
+#[must_use]
 pub fn nanos_to_secs(nanos: u64) -> f64 {
     let seconds = nanos / NANOSECONDS_IN_SECOND;
     let rem_nanos = nanos % NANOSECONDS_IN_SECOND;
     (seconds as f64) + (rem_nanos as f64) / (NANOSECONDS_IN_SECOND as f64)
 }
 
 /// Converts nanoseconds (ns) to milliseconds (ms).
+#[must_use]
 pub const fn nanos_to_millis(nanos: u64) -> u64 {
     nanos / NANOSECONDS_IN_MILLISECOND
 }
 
 /// Converts nanoseconds (ns) to microseconds (μs).
+#[must_use]
 pub const fn nanos_to_micros(nanos: u64) -> u64 {
     nanos / NANOSECONDS_IN_MICROSECOND
 }

crates/core/src/ffi/datetime.rs

@@ -72,13 +72,13 @@ pub extern "C" fn nanos_to_secs(nanos: u64) -> f64 {
 /// Converts nanoseconds (ns) to milliseconds (ms).
 #[cfg(feature = "ffi")]
 #[unsafe(no_mangle)]
-pub extern "C" fn nanos_to_millis(nanos: u64) -> u64 {
+pub const extern "C" fn nanos_to_millis(nanos: u64) -> u64 {
     crate::datetime::nanos_to_millis(nanos)
 }
 
 /// Converts nanoseconds (ns) to microseconds (μs).
 #[cfg(feature = "ffi")]
 #[unsafe(no_mangle)]
-pub extern "C" fn nanos_to_micros(nanos: u64) -> u64 {
+pub const extern "C" fn nanos_to_micros(nanos: u64) -> u64 {
     crate::datetime::nanos_to_micros(nanos)
 }

crates/infrastructure/src/redis/msgbus.rs

@@ -91,7 +91,6 @@ impl MessageBusDatabaseAdapter for RedisMessageBusDatabase {
     /// Returns an error if:
     /// - The database configuration is missing in `config`.
     /// - Establishing the Redis connection for publishing fails.
-    ///
     fn new(
         trader_id: TraderId,
         instance_id: UUID4,