INTERNAL: Use isEmpty method to simplify empty checking

Author: junghoon-vans

src/main/java/net/spy/memcached/ArcusClient.java

@@ -2305,7 +2305,7 @@ public List<SMGetTrimKey> getTrimmedKeys() {
 
       @Override
       public CollectionOperationStatus getOperationStatus() {
-        if (failedOperationStatus.size() > 0) {
+        if (!failedOperationStatus.isEmpty()) {
           return new CollectionOperationStatus(failedOperationStatus.get(0));
         }
         return new CollectionOperationStatus(resultOperationStatus.get(0));
@@ -2564,7 +2564,7 @@ public List<SMGetTrimKey> getTrimmedKeys() {
 
       @Override
       public CollectionOperationStatus getOperationStatus() {
-        if (failedOperationStatus.size() > 0) {
+        if (!failedOperationStatus.isEmpty()) {
           return new CollectionOperationStatus(failedOperationStatus.get(0));
         }
         return new CollectionOperationStatus(resultOperationStatus.get(0));

src/main/java/net/spy/memcached/ArcusKetamaNodeLocator.java

@@ -301,7 +301,7 @@ private void removeHash(MemcachedNode node) {
         SortedSet<MemcachedNode> nodeSet = ketamaNodes.get(k);
         assert nodeSet != null;
         nodeSet.remove(node);
-        if (nodeSet.size() == 0) {
+        if (nodeSet.isEmpty()) {
           ketamaNodes.remove(k);
         }
       }
@@ -338,7 +338,7 @@ private void insertHashOfJOIN(MemcachedNode node) {
         Long k = getKetamaHashPoint(digest, h);
         SortedSet<MemcachedNode> alterSet = ketamaAlterNodes.get(k);
         if (alterSet != null && alterSet.remove(node)) {
-          if (alterSet.size() == 0) {
+          if (alterSet.isEmpty()) {
             ketamaAlterNodes.remove(k);
           }
           SortedSet<MemcachedNode> existSet = ketamaNodes.get(k);

src/main/java/net/spy/memcached/ArcusReplKetamaNodeLocator.java

@@ -410,7 +410,7 @@ private void removeHash(MemcachedReplicaGroup group) {
         Long k = getKetamaHashPoint(digest, h);
         SortedSet<MemcachedReplicaGroup> nodeSet = ketamaGroups.get(k);
         nodeSet.remove(group);
-        if (nodeSet.size() == 0) {
+        if (nodeSet.isEmpty()) {
           ketamaGroups.remove(k);
         }
       }
@@ -444,7 +444,7 @@ private void insertHashOfJOIN(MemcachedReplicaGroup group) {
         Long k = getKetamaHashPoint(digest, h);
         SortedSet<MemcachedReplicaGroup> alterSet = ketamaAlterGroups.get(k);
         if (alterSet != null && alterSet.remove(group)) {
-          if (alterSet.size() == 0) {
+          if (alterSet.isEmpty()) {
             ketamaAlterGroups.remove(k);
           }
           SortedSet<MemcachedReplicaGroup> existSet = ketamaGroups.get(k);

src/main/java/net/spy/memcached/CacheManager.java

@@ -439,7 +439,7 @@ private String getAddressListString(List<String> children) {
    * @param children new children node list
    */
   public void commandCacheListChange(List<String> children) {
-    if (children.size() == 0) {
+    if (children.isEmpty()) {
       getLogger().error("Cannot find any cache nodes for your service code. " +
               "Please contact Arcus support to solve this problem. " +
               "[serviceCode=" + serviceCode + ", adminSessionId=0x" +
@@ -493,7 +493,7 @@ public void setReadingCacheList(boolean reading) {
   @Override
   public boolean commandCloudStatChange(List<String> children) {
     // return true if STATE == PREPARED.
-    if (children.size() == 0) {
+    if (children.isEmpty()) {
       /*
        * case 1 : No child znode in clout_stat znode.
        * case 2 : Starting migration.

src/main/java/net/spy/memcached/collection/ElementMultiFlagsFilter.java

@@ -67,7 +67,7 @@ public ElementMultiFlagsFilter addCompValue(byte[] compValue) {
                       + MAX_EFLAGS);
     }
 
-    if (this.compValue.size() > 0
+    if (!this.compValue.isEmpty()
             && this.compValue.get(0).length != compValue.length) {
       throw new IllegalArgumentException(
               "Length of comparison value must be same with "

src/main/java/net/spy/memcached/collection/MapDelete.java

@@ -66,7 +66,7 @@ public String stringify() {
       return str;
     }
 
-    if (mkeyList.size() == 0) {
+    if (mkeyList.isEmpty()) {
       additionalArgs = null;
     } else {
       additionalArgs = getSpaceSeparatedMkeys().getBytes();

src/main/java/net/spy/memcached/collection/MapGet.java

@@ -67,7 +67,7 @@ public String stringify() {
       return str;
     }
 
-    if (mkeyList.size() == 0) {
+    if (mkeyList.isEmpty()) {
       additionalArgs = null;
     } else {
       additionalArgs = getSpaceSeparatedMkeys().getBytes();

src/main/java/net/spy/memcached/internal/BroadcastFuture.java

@@ -65,7 +65,7 @@ public T get(long duration, TimeUnit units)
           MemcachedConnection.opSucceeded(op);
         }
       }
-      if (timedoutOps.size() > 0) {
+      if (!timedoutOps.isEmpty()) {
         throw new CheckedOperationTimeoutException(duration, units, timedoutOps);
       }
     } else {

src/main/java/net/spy/memcached/internal/BulkGetFuture.java

@@ -86,7 +86,7 @@ public Map<String, T> getSome(long duration, TimeUnit units)
           throws InterruptedException, ExecutionException {
     Collection<Operation> timedoutOps = new HashSet<Operation>();
     Map<String, T> ret = internalGet(duration, units, timedoutOps);
-    if (timedoutOps.size() > 0) {
+    if (!timedoutOps.isEmpty()) {
       isTimeout = true;
       LoggerFactory.getLogger(getClass()).warn(
               new CheckedOperationTimeoutException(duration, units, timedoutOps).getMessage());
@@ -106,7 +106,7 @@ public Map<String, T> get(long duration, TimeUnit units)
           throws InterruptedException, ExecutionException, TimeoutException {
     Collection<Operation> timedoutOps = new HashSet<Operation>();
     Map<String, T> ret = internalGet(duration, units, timedoutOps);
-    if (timedoutOps.size() > 0) {
+    if (!timedoutOps.isEmpty()) {
       isTimeout = true;
       throw new CheckedOperationTimeoutException(duration, units, timedoutOps);
     }
@@ -148,7 +148,7 @@ private Map<String, T> internalGet(long to, TimeUnit unit,
           MemcachedConnection.opSucceeded(op);
         }
       }
-      if (timedoutOps.size() > 0) {
+      if (!timedoutOps.isEmpty()) {
         MemcachedConnection.opsTimedOut(timedoutOps);
       }
     } else {

src/main/java/net/spy/memcached/internal/BulkOperationFuture.java

@@ -78,7 +78,7 @@ public Map<String, T> get(long duration,
           MemcachedConnection.opSucceeded(op);
         }
       }
-      if (timedoutOps.size() > 0) {
+      if (!timedoutOps.isEmpty()) {
         MemcachedConnection.opsTimedOut(timedoutOps);
         throw new CheckedOperationTimeoutException(duration, units, timedoutOps);
       }

src/main/java/net/spy/memcached/internal/CollectionGetBulkFuture.java

@@ -68,7 +68,7 @@ public T get(long duration, TimeUnit units)
           MemcachedConnection.opSucceeded(op);
         }
       }
-      if (timedoutOps.size() > 0) {
+      if (!timedoutOps.isEmpty()) {
         MemcachedConnection.opsTimedOut(timedoutOps);
         throw new CheckedOperationTimeoutException(duration, units, timedoutOps);
       }

src/main/java/net/spy/memcached/internal/PipedCollectionFuture.java

@@ -73,7 +73,7 @@ public Map<K, V> get(long duration, TimeUnit units)
           MemcachedConnection.opSucceeded(op);
         }
       }
-      if (timedoutOps.size() > 0) {
+      if (!timedoutOps.isEmpty()) {
         MemcachedConnection.opTimedOut(timedoutOps.iterator().next());
         throw new CheckedOperationTimeoutException(duration, units, timedoutOps);
       }

src/main/java/net/spy/memcached/protocol/TCPMemcachedNodeImpl.java

@@ -626,7 +626,7 @@ public final void fixupOps() {
   }
 
   public final void authComplete() {
-    if (reconnectBlocked != null && reconnectBlocked.size() > 0) {
+    if (reconnectBlocked != null && !reconnectBlocked.isEmpty()) {
       inputQueue.addAll(reconnectBlocked);
     }
     authLatch.countDown();
@@ -635,12 +635,12 @@ public final void authComplete() {
   public final void setupForAuth(String cause) {
     if (shouldAuth) {
       authLatch = new CountDownLatch(1);
-      if (inputQueue.size() > 0) {
+      if (!inputQueue.isEmpty()) {
         reconnectBlocked = new ArrayList<Operation>(
                 inputQueue.size() + 1);
         inputQueue.drainTo(reconnectBlocked);
       }
-      assert (inputQueue.size() == 0);
+      assert (inputQueue.isEmpty());
       setupResend(cause);
     } else {
       authLatch = new CountDownLatch(0);