FIX: Invalid isTimeout value when creating BulkGetFuture with another object. #717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brido4125 |
brido4125
force-pushed
the
fix/frontBulkFuture
branch
from
6ad0f31 to
4fa63da
Compare
brido4125
changed the title
uhm0311
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
요구사항
FrontCacheBulkGetFuture타입을 리턴받은 응용이부모 클래스의 메서드인
isTimeout()을 호출할 경우정확한 값을 리턴하지 않는 문제가 있다.
AtomicBoolean을 이용해서copy의 대상이 되는
BulkGetFuture의isTimeout값을새로 생성될
FrontCacheBulkGetFuture에서isTimeout()을호출할 때 사용하도록 한다.
호출되는 값의 결과가 연산 완료 전/후에 따라 변경되기에
AtomicBoolean을 사용하였다.