INTERNAL: Call new merge method instead of existing one for new SMGetResult #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhpark816
reviewed
Mar 29, 2024
| @@ -183,4 +128,60 @@ private void refineTrimmedKeys() { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| @Deprecated | |||
| private void mergeSMGetElementsOld(final List<SMGetElement<T>> eachResult) { | |||
There was a problem hiding this comment.
함수 자체의 위치를 변경하였네요.
함수의 위치는 그대로 유지하고,
함수 명, 접근 제한자만 변경하고 Deprecate 처리해 두면 나을 것 같습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#720
위 PR에서 추가한 메소드를 사용하도록 변경합니다.
기존 메소드는
@Deprecated를 붙인 채로 두었는데, 아예 삭제할까요?