INTERNAL: remove reverse local variable. #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brido4125
force-pushed
the
reverse/bopPosi
branch
from
d54528d to
ba7a4f4
Compare
jhpark816
reviewed
Dec 20, 2024
| BTreeGetByPosition get = new BTreeGetByPosition(order, from, to); | ||
| boolean reverse = from > to; | ||
| return asyncBopGetByPosition(key, get, reverse, collectionTranscoder); | ||
| return asyncBopGetByPosition(key, new BTreeGetByPosition(order, from, to), collectionTranscoder); |
There was a problem hiding this comment.
기존과 같이 2 line으로 읽기에 편한 것 같습니다.
BTreeGetByPosition get = new BTreeGetByPosition(order, from, to);
return asyncBopGetByPosition(key, get, collectionTranscoder);
brido4125
force-pushed
the
reverse/bopPosi
branch
from
ba7a4f4 to
56a2adc
Compare
jhpark816
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Related Issue
https://github.com/jam2in/arcus-works/issues/656
⌨️ What I did
reverse 변수 제거 후, 인자 값으로 불리언 처리