Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLEANUP: tidy TCPMemcachedNodeImpl #880

Merged
merged 1 commit into from
Feb 20, 2025
Merged

CLEANUP: tidy TCPMemcachedNodeImpl #880

merged 1 commit into from
Feb 20, 2025

Conversation

oliviarla
Copy link
Collaborator

πŸ”— Related Issue

⌨️ What I did

  • TCPMemcachedNodeImpl 클래슀λ₯Ό μ •λ¦¬ν–ˆμŠ΅λ‹ˆλ‹€.
    • transitionWriteItem λ©”μ„œλ“œλ₯Ό μ œκ±°ν•©λ‹ˆλ‹€.
    • getBuffer λ©”μ„œλ“œλ₯Ό ν•œλ²ˆλ§Œ ν˜ΈμΆœν•˜λ„λ‘ ν•©λ‹ˆλ‹€.

@oliviarla oliviarla requested a review from jhpark816 February 20, 2025 08:03
jhpark816
jhpark816 reviewed Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 μ™„λ£Œ

src/main/java/net/spy/memcached/protocol/TCPMemcachedNodeImpl.java
transitionWriteItem();

Operation op = removeCurrentWriteOp();
getLogger().debug("Finished writing %s", op);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ•„λž˜μ™€ 같이 assert 문을 μΆ”κ°€ν•˜μ—¬ o와 op 객체가 동일함을 ν‘œν˜„ν•΄ μ£Όλ©΄ μ’‹κ² μŠ΅λ‹ˆλ‹€.

          Operation op = removeCurrentWriteOp();
          assert o == op;          
          getLogger().debug("Finished writing %s", op);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

λ°˜μ˜ν–ˆμŠ΅λ‹ˆλ‹€.

@jhpark816 jhpark816 merged commit a3bd40e into naver:develop Feb 20, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhpark816 jhpark816 jhpark816 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oliviarla @jhpark816