CLEANUP: tidy TCPMemcachedNodeImpl

src/main/java/net/spy/memcached/MemcachedNode.java

@@ -72,11 +72,6 @@ public interface MemcachedNode {
    */
   void fillWriteBuffer(boolean optimizeGets);
 
-  /**
-   * Transition the current write item into a read state.
-   */
-  void transitionWriteItem();
-
   /**
    * Get the operation at the top of the queue that is requiring input.
    */

src/main/java/net/spy/memcached/MemcachedNodeROImpl.java

@@ -177,10 +177,6 @@ public void setupResend(String cause) {
     throw new UnsupportedOperationException();
   }
 
-  public void transitionWriteItem() {
-    throw new UnsupportedOperationException();
-  }
-
   public int writeSome() throws IOException {
     throw new UnsupportedOperationException();
   }

src/main/java/net/spy/memcached/protocol/TCPMemcachedNodeImpl.java

@@ -78,7 +78,7 @@ public abstract class TCPMemcachedNodeImpl extends SpyObject
   private final AtomicLong timeoutStartNanos = new AtomicLong(0);
   private boolean toRatioEnabled = false;
   private int[] toCountArray;
-  private final static int MAX_TOCOUNT = 100;   /* to count array size */
+  private static final int MAX_TOCOUNT = 100;   /* to count array size */
   private int toCountIdx;         /* to count array index */
   private int toRatioMax;         /* maximum timeout ratio */
   private int toRatioNow;         /* current timeout ratio */
@@ -260,9 +260,12 @@ public final void fillWriteBuffer(boolean shouldOptimize) {
         getWbuf().put(b);
         getLogger().debug("After copying stuff from %s: %s",
                 o, getWbuf());
-        if (!o.getBuffer().hasRemaining()) {
+        if (!obuf.hasRemaining()) {
           o.writeComplete();
-          transitionWriteItem();
+
+          Operation op = removeCurrentWriteOp();
+          assert o == op;
+          getLogger().debug("Finished writing %s", op);
 
           preparePending();
           if (shouldOptimize) {
@@ -288,12 +291,6 @@ public final void fillWriteBuffer(boolean shouldOptimize) {
     }
   }
 
-  public final void transitionWriteItem() {
-    Operation op = removeCurrentWriteOp();
-    assert op != null : "There is no write item to transition";
-    getLogger().debug("Finished writing %s", op);
-  }
-
   protected abstract void optimize();
 
   public final Operation getCurrentReadOp() {

src/test/java/net/spy/memcached/MockMemcachedNode.java

@@ -75,10 +75,6 @@ public void fillWriteBuffer(boolean optimizeGets) {
     // noop
   }
 
-  public void transitionWriteItem() {
-    // noop
-  }
-
   public Operation getCurrentReadOp() {
     return null;
   }