Skip to content

INTERNAL: improve refineTrimmedKeys method using Java 8 removeIf #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

junhyeongkim2
Copy link

@junhyeongkim2 junhyeongkim2 commented May 7, 2025

๐Ÿ”— Related Issue

  • ์ด PR์€ SMGetResultImpl ํด๋ž˜์Šค์˜ refineTrimmedKeys ๋ฉ”์„œ๋“œ๋ฅผ ๊ฐœ์„ ํ•˜์—ฌ Java 8์˜ removeIf ๊ธฐ๋Šฅ์„ ํ™œ์šฉํ•ฉ๋‹ˆ๋‹ค.

โŒจ๏ธ What I did

  • ๊ธฐ์กด ์ฝ”๋“œ์˜ Iterator๋ฅผ ์‚ฌ์šฉํ•œ ๋ฐฉ์‹์—์„œ removeIf ๋ฉ”์„œ๋“œ๋ฅผ ์‚ฌ์šฉํ•˜๋Š” ๋ฐฉ์‹์œผ๋กœ ๋ณ€๊ฒฝํ–ˆ์Šต๋‹ˆ๋‹ค
  • "FIXME: use removeIf with entrySet() when upgrading java version 8" ์ฃผ์„์„ ์ œ๊ฑฐํ–ˆ์Šต๋‹ˆ๋‹ค
  • ์ฝ”๋“œ์˜ ๊ฐ€๋…์„ฑ ๋ฐ ์œ ์ง€๋ณด์ˆ˜์„ฑ์„ ํ–ฅ์ƒ์‹œ์ผฐ์Šต๋‹ˆ๋‹ค
  • ์‚ฌ์šฉํ•˜์ง€ ์•Š๋Š” import ๋ฌธ์„ ์ œ๊ฑฐํ•˜์˜€์Šต๋‹ˆ๋‹ค. (Iterator, Map, BKeyObject)

@jhpark816 jhpark816 requested a review from oliviarla May 8, 2025 01:54
@oliviarla
Copy link
Collaborator

@junhyeongkim2
์•ˆ๋…•ํ•˜์„ธ์š”, PR ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค!
์ปค๋ฐ‹์„ 1๊ฐœ๋กœ ํ•ฉ์ณ์ฃผ์‹œ๊ณ , ์ถฉ๋Œ ํ•ด๊ฒฐํ•ด์ฃผ์‹œ๋ฉด ๋ฆฌ๋ทฐ ์‹œ์ž‘ํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@junhyeongkim2 junhyeongkim2 force-pushed the improve-smget-result-implementation branch 3 times, most recently from 21a7351 to f1b2985 Compare May 8, 2025 06:13
@junhyeongkim2 junhyeongkim2 reopened this May 8, 2025
@junhyeongkim2 junhyeongkim2 force-pushed the improve-smget-result-implementation branch from f1b2985 to 84bf779 Compare May 8, 2025 06:57
@junhyeongkim2
Copy link
Author

@oliviarla
์•ˆ๋…•ํ•˜์„ธ์š”, ๋‹ต๋ณ€ ๊ฐ์‚ฌ๋“œ๋ฆฝ๋‹ˆ๋‹ค!
์›๋ž˜ master ๋ธŒ๋žœ์น˜์—์„œ ๋ธŒ๋žœ์น˜๋ฅผ ๋”ฐ์„œ ์ž‘์—…์„ ์‹œ์ž‘ํ–ˆ์œผ๋‚˜,
์ถฉ๋Œ์ด ๋งŽ์ด ๋ฐœ์ƒํ•˜์—ฌ develop ๋ธŒ๋žœ์น˜๋กœ ๋ณ€๊ฒฝ ๋ฐ ์ปค๋ฐ‹ 1๊ฐœ๋กœ ํ•ฉ์น˜๊ณ  ์ถฉ๋Œ ํ•ด๊ฒฐํ•˜์˜€์Šต๋‹ˆ๋‹ค!
ํ˜น์‹œ ์ˆ˜์ • ์‚ฌํ•ญ ์žˆ๋‹ค๋ฉด ์•Œ๋ ค์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค!

@oliviarla
Copy link
Collaborator

@junhyeongkim2
๋ฒ„๊ทธ๋ฅผ ๊ณ ์น˜๋Š” ์ปค๋ฐ‹์ด ์•„๋‹ˆ๋ผ์„œ, ์ปค๋ฐ‹ ๋ฉ”์‹œ์ง€๋ฅผ FIX: ๋Œ€์‹  INTERNAL: ๋กœ ๋ณ€๊ฒฝํ•ด์ฃผ์‹œ๋ฉด ๊ฐ์‚ฌํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค.

@junhyeongkim2 junhyeongkim2 changed the title FIX: improve refineTrimmedKeys method using Java 8 removeIf INTERNAL:: improve refineTrimmedKeys method using Java 8 removeIf May 8, 2025
@junhyeongkim2 junhyeongkim2 changed the title INTERNAL:: improve refineTrimmedKeys method using Java 8 removeIf INTERNAL: improve refineTrimmedKeys method using Java 8 removeIf May 8, 2025
@junhyeongkim2 junhyeongkim2 force-pushed the improve-smget-result-implementation branch from 84bf779 to 038c4c9 Compare May 8, 2025 08:38
@junhyeongkim2
Copy link
Author

junhyeongkim2 commented May 8, 2025

@oliviarla
์•Œ๋ ค์ฃผ์…”์„œ ๊ฐ์‚ฌํ•ฉ๋‹ˆ๋‹ค! :) PR ์ œ๋ชฉ, ์ปค๋ฐ‹ ๋ฉ”์„ธ์ง€ ๋ชจ๋‘ FIX: -> INTERNAL: ์œผ๋กœ ์ˆ˜์ • ์™„๋ฃŒํ•˜์˜€์Šต๋‹ˆ๋‹ค.

@oliviarla oliviarla requested a review from jhpark816 May 8, 2025 08:51
@jhpark816 jhpark816 merged commit 87e22bf into naver:develop May 8, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants