Revert "Add caching when not dirty" (#65)

This reverts commit d7fbe5b.
naver · Oct 8, 2021 · af1fdce · af1fdce
1 parent ae09333
commit af1fdce
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 39 deletions.
diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/ArbitraryBuilder.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/ArbitraryBuilder.java
@@ -173,10 +173,6 @@ public ArbitraryBuilder<T> generator(ArbitraryGenerator generator) {
 	}
 
 	public Arbitrary<T> build() {
-		if (!this.isDirty() && this.tree.getArbitrary() != null) { // not build if not changed
-			return this.tree.getArbitrary();
-		}
-
 		ArbitraryBuilder<T> buildArbitraryBuilder = this.copy();
 		return buildArbitraryBuilder.tree.result(() -> {
 			ArbitraryTree<T> buildTree = buildArbitraryBuilder.tree;

diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/arbitrary/ArbitraryTree.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/arbitrary/ArbitraryTree.java
@@ -131,12 +131,7 @@ public Arbitrary<T> result(
 		ArbitraryValidator validator,
 		boolean validOnly
 	) {
-		return new ArbitraryValue(
-			generateArbitrary,
-			validator,
-			validOnly,
-			new ConcurrentHashMap<>()
-		);
+		return new ArbitraryValue(generateArbitrary, validator, validOnly, new ConcurrentHashMap<>());
 	}
 
 	@SuppressWarnings("unchecked")

diff --git a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java
@@ -59,7 +59,6 @@
 import com.navercorp.fixturemonkey.ArbitraryBuilder;
 import com.navercorp.fixturemonkey.FixtureMonkey;
 import com.navercorp.fixturemonkey.generator.BuilderArbitraryGenerator;
-import com.navercorp.fixturemonkey.test.ComplexManipulatorTest.ComplexClass;
 
 class FixtureMonkeyTest {
 	private final FixtureMonkey sut = FixtureMonkey.builder()
@@ -1457,34 +1456,6 @@ void copyValidOnly() {
 				.sample());
 	}
 
-	@Property
-	void giveMeBuilderCachedReturnsDiff() {
-		// given
-		Arbitrary<ComplexClass> sut = this.sut.giveMeBuilder(ComplexClass.class)
-			.build();
-
-		// when
-		ComplexClass actual1 = sut.sample();
-		ComplexClass actual2 = sut.sample();
-
-		then(actual1).isNotEqualTo(actual2);
-	}
-
-	@Property
-	void giveMeBuilderFixedCachedReturnsDiff() {
-		// given
-		Arbitrary<ComplexClass> sut = this.sut.giveMeBuilder(ComplexClass.class)
-			.apply((it, builder) -> {
-			})
-			.build();
-
-		// when
-		ComplexClass actual1 = sut.sample();
-		ComplexClass actual2 = sut.sample();
-
-		then(actual1).isNotEqualTo(actual2);
-	}
-
 	@Data
 	public static class IntegerWrapperClass {
 		int value;