diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/ArbitraryBuilder.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/ArbitraryBuilder.java index 66cc5ccdb..8c53bb20a 100644 --- a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/ArbitraryBuilder.java +++ b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/ArbitraryBuilder.java @@ -173,10 +173,6 @@ public ArbitraryBuilder generator(ArbitraryGenerator generator) { } public Arbitrary build() { - if (!this.isDirty() && this.tree.getArbitrary() != null) { // not build if not changed - return this.tree.getArbitrary(); - } - ArbitraryBuilder buildArbitraryBuilder = this.copy(); return buildArbitraryBuilder.tree.result(() -> { ArbitraryTree buildTree = buildArbitraryBuilder.tree; diff --git a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/arbitrary/ArbitraryTree.java b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/arbitrary/ArbitraryTree.java index 0c9d4ff6e..02756de3d 100644 --- a/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/arbitrary/ArbitraryTree.java +++ b/fixture-monkey/src/main/java/com/navercorp/fixturemonkey/arbitrary/ArbitraryTree.java @@ -131,12 +131,7 @@ public Arbitrary result( ArbitraryValidator validator, boolean validOnly ) { - return new ArbitraryValue( - generateArbitrary, - validator, - validOnly, - new ConcurrentHashMap<>() - ); + return new ArbitraryValue(generateArbitrary, validator, validOnly, new ConcurrentHashMap<>()); } @SuppressWarnings("unchecked") diff --git a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java index 24d4971d2..91236e190 100644 --- a/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java +++ b/fixture-monkey/src/test/java/com/navercorp/fixturemonkey/test/FixtureMonkeyTest.java @@ -59,7 +59,6 @@ import com.navercorp.fixturemonkey.ArbitraryBuilder; import com.navercorp.fixturemonkey.FixtureMonkey; import com.navercorp.fixturemonkey.generator.BuilderArbitraryGenerator; -import com.navercorp.fixturemonkey.test.ComplexManipulatorTest.ComplexClass; class FixtureMonkeyTest { private final FixtureMonkey sut = FixtureMonkey.builder() @@ -1457,34 +1456,6 @@ void copyValidOnly() { .sample()); } - @Property - void giveMeBuilderCachedReturnsDiff() { - // given - Arbitrary sut = this.sut.giveMeBuilder(ComplexClass.class) - .build(); - - // when - ComplexClass actual1 = sut.sample(); - ComplexClass actual2 = sut.sample(); - - then(actual1).isNotEqualTo(actual2); - } - - @Property - void giveMeBuilderFixedCachedReturnsDiff() { - // given - Arbitrary sut = this.sut.giveMeBuilder(ComplexClass.class) - .apply((it, builder) -> { - }) - .build(); - - // when - ComplexClass actual1 = sut.sample(); - ComplexClass actual2 = sut.sample(); - - then(actual1).isNotEqualTo(actual2); - } - @Data public static class IntegerWrapperClass { int value;