Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor customizeProperty works in order #1014

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Conversation

seongahjo
Copy link
Contributor

@seongahjo seongahjo commented Jul 27, 2024

Summary

Refactor customizeProperty works in order

(Optional): Description

ArbitraryBuilder API customizeProperty is affected by order from 1.1.0.

For example, the results of two examples are different.

.setExp(StringValue::value, "abcdef")
.customizeProperty(typedString<String>("value")) {
    it.map { str -> str.substring(0..2) }
}

result -> `abc`
.customizeProperty(typedString<String>("value")) {
    it.filter { value -> value.length > 5 }
}
.setExp(StringValue::value, "fixed")

result -> "fixed"

How Has This Been Tested?

  • customizePropertyAfterSet
  • customizePropertyIgnoredIfSet

Is the Document updated?

Later

@seongahjo seongahjo force-pushed the sa/customizeProperty branch from b03406d to e1d1c9a Compare July 27, 2024 06:19
@seongahjo seongahjo merged commit d3fbc67 into 1.1.x Jul 30, 2024
12 checks passed
@seongahjo seongahjo deleted the sa/customizeProperty branch July 30, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant