Add StringCombinableArbitrary for easy efficient customisation #1179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
acktsap,
benelog,
jwChung,
mhyeon-lee and
SooKim1110
seongahjo
changed the title
seongahjo
force-pushed
the
main
branch
4 times, most recently
from
e5e944e to
3ff3180
Compare
acktsap
reviewed
Apr 23, 2025
| * @return the pattern matched StringCombinableArbitrary | ||
| */ | ||
| default StringCombinableArbitrary pattern(int tries, String stringPattern) { | ||
| Pattern pattern = Pattern.compile(stringPattern); |
There was a problem hiding this comment.
How about adding method taking Pattern class? It seems immutable
| @@ -0,0 +1 @@ | |||
| com.navercorp.fixturemonkey.api.jqwik.JqwikStringCombinableArbitrary | |||
There was a problem hiding this comment.
Seems it's already loaded (it's inside the api module). Is that ok?
There was a problem hiding this comment.
As I test it, SPI does not load the implementation implicitly.
It should specify the implementation in META-INF/services.
I also did not find the following specification in the document.
https://docs.oracle.com/javase/tutorial/sound/SPI-intro.html
|
|
||
| override fun alphabetic(): StringCombinableArbitrary = KotestStringCombinableArbitrary( | ||
| Arb.string( | ||
| codepoints = Arb.codepoints().filter { it.value.toChar() in 'a'..'z' } |
There was a problem hiding this comment.
Is it ok to include lower case only?
seongahjo
force-pushed
the
sa/string-combinable-arbitrary
branch
from
6629cd3 to
f581ee8
Compare
seongahjo
force-pushed
the
sa/string-combinable-arbitrary
branch
from
f581ee8 to
b115253
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add StringCombinableArbitrary for easy efficient customisation
(Optional): Description
providing below APIs to customize the randomly generated String
How Has This Been Tested?
Is the Document updated?
Later