Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add creating-test-objects page of get-started section for kor doc #875

Merged

Conversation

songkg7
Copy link
Contributor

@songkg7 songkg7 commented Jan 15, 2024

Summary

Translating the creating-test-object documentation into Korean

related to #864

(Optional): Description

  • The title of the section called Getting started hasn't been translated yet, but it would be nice to see it translated to 시작하기. if that's okay, I'll work on it later.

How Has This Been Tested?

execute npm start

@songkg7 songkg7 changed the title Add creating-test-object page of get-startted sction for kor doc Add creating-test-object page of get-started sction for kor doc Jan 15, 2024
@songkg7 songkg7 changed the title Add creating-test-object page of get-started sction for kor doc Add creating-test-object page of get-started section for kor doc Jan 15, 2024
@songkg7 songkg7 changed the title Add creating-test-object page of get-started section for kor doc Add creating-test-objects page of get-started section for kor doc Jan 15, 2024
Copy link
Contributor

@seongahjo seongahjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@SooKim1110
Copy link
Contributor

Getting started을 시작하기로 변경하는 것 좋은 것 같습니다! 👍

@SooKim1110
Copy link
Contributor

SooKim1110 commented Jan 16, 2024

@songkg7 님, 늦게 확인하였는데 #872 에서 표들도 한국어로 번역되면 좋을 것 같습니다!

괜찮으시다면 이 PR에서 함께 번역해주시면 감사하겠습니다. 🙇

@songkg7
Copy link
Contributor Author

songkg7 commented Jan 16, 2024

Changes

  1. PR description 에서 상술했던, Getting Started시작하기로 번역하였습니다.
  2. then 섹션에서then 절에서 로 수정하였습니다.
  3. 이전 Add requirements page of get-started section for kor doc #872 테이블의 내용을 피드백에 의해 추가 번역합니다.

@songkg7 songkg7 requested a review from SooKim1110 January 16, 2024 06:47
@SooKim1110 SooKim1110 merged commit 4e6c42c into naver:docs/kor-translation Jan 16, 2024
@songkg7 songkg7 deleted the docs-creating-test-objects branch January 16, 2024 07:15
SooKim1110 pushed a commit that referenced this pull request Mar 18, 2024
* docs: creating-test-objects.md translation for kor

* fix(docs): title

* fix(docs): typo

* docs: section title translation

* docs: table translation

* fix: typo

* fix: context

* fix: typo

* fix: typo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants