Add a new module for Spring Framework #899
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seongahjo
force-pushed
the
sa/add-fixture-spring
branch
from
14c7881 to
2ad58f5
Compare
seongahjo
force-pushed
the
sa/add-fixture-spring
branch
9 times, most recently
from
8f33c31 to
220e7ca
Compare
seongahjo
force-pushed
the
sa/add-fixture-spring
branch
from
ad41402 to
a86031b
Compare
seongahjo
force-pushed
the
sa/add-fixture-spring
branch
5 times, most recently
from
ef64677 to
a825f51
Compare
|
|
||
| dependencies { | ||
| api(project(":fixture-monkey")) | ||
| implementation("org.springframework.boot:spring-boot-starter-aop") |
| implementation("org.springframework.boot:spring-boot-starter-aop") | ||
| implementation("org.springframework.boot:spring-boot-starter-test") | ||
| implementation("io.projectreactor:reactor-core:3.5.6") | ||
| implementation("org.projectlombok:lombok:${Versions.LOMBOK}") |
|
이 모듈이 무엇을 하려고 하는건지는 배경이 없어서 정확히 모르겠지만.. 필요성이 있어 만든다고 하더라도 spring framework 라는 대표성을 가져가기에는 specific 한 기능(AOP) 활용에 맞춰져 있어 다른 이름이었으면 좋겠습니다 |
seongahjo
force-pushed
the
sa/add-fixture-spring
branch
from
a825f51 to
53a6f0a
Compare
|
@flex-myeonghyeon |
|
실제 프로덕션에서 사용하기 위해서는 생각보다 고려해야할 사항들이 많아서 다음 메이저 버전(1.2.0)에서 다시 고민을 해보겠습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe what feature is implemented by this PR.
If there is a related issue, write the issue number and link
(Optional): Description
Describe your changes in detail
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Is the Document updated?
We recommend that the corresponding documentation for this feature or change is updated within the pull request
If the update is scheduled for later, please specify and add the necessary information to the discussion page.