Fixes #84: Resolve undefined symbol error in Boost.NumPy after successful installation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace direct access to PyArray_Descr.elsize with the recommended PyDataType_ELSIZE macro to get the element size of a dtype. This change follows NumPy's best practices for accessing dtype properties and improves maintainability as it uses the official API. The rest of the changes are just indentation fixes to maintain consistent code style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Title: Fix import error after successful installation (Fixes #84)
Issue Reference:
This pull request addresses the issue outlined in Issue #84 concerning the import error encountered when running
import *after a successful installation of the Boost.NumPy library.Issue Summary:
Users reported an error message indicating an undefined symbol related to Boost.Python and NumPy compatibility, specifically:
Changes Made:
Issue Analysis:
get_itemsize()method.Code Modifications:
get_itemsize()method indtype.cppwas updated to implement the correct API, utilizingPyDataType_ELSIZEto align with the expected functionality.Build and Dependency Management:
cmake,build-essential,python3-dev, andlibboost-all-dev.Testing:
boost.numpywas functional:Verification:
The library was tested following installation, and the import error has been resolved. The modifications made successfully allow for the expected functionality without any residual issues.
Conclusion:
This pull request resolves the issue detailed in #84 and ensures compatibility between Boost.Python and NumPy. It includes all necessary changes to eliminate the import error.
Note: This pull request contains the modification "Fixes #84" for issue tracking and resolution acknowledgment.
Please review the changes made and test locally to verify that the issue is resolved in your environment. Thank you for your attention to this matter!