Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: custom Link element should handle when href is undefined #899

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

charleslavon
Copy link
Collaborator

@charleslavon charleslavon commented Jan 2, 2024

Some <Link> instances define their destination usingto instead of href. This PR handles that case and fixes broken links like communities and activity feed on DevHub

Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 5:26pm
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 5:26pm

@charleslavon charleslavon merged commit 1d5b5af into develop Jan 2, 2024
4 of 5 checks passed
@charleslavon charleslavon deleted the fix_custom_href_links branch January 2, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-for-release Use when a PR's description is should not be included in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants