Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Session lost with MyNearWallet #915

Merged
merged 2 commits into from
Jan 10, 2024

Conversation

erditkurteshiSQA
Copy link
Contributor

After some investigations, I reviewed the pull request (PR) at #903
which appears to be the cause of session loss and sign-out when refreshing the page.

To address this issue, I propose a set of changes that will fix the issue: #910.

  • Added checks walletSelectorState and fastAuthWallet.

@erditkurteshiSQA erditkurteshiSQA added the bug Something isn't working. Highlights a PR's description in the 'Fixes' changelog section label Jan 9, 2024
@erditkurteshiSQA erditkurteshiSQA self-assigned this Jan 9, 2024
Copy link

vercel bot commented Jan 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
near-discovery ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 9:15am
near-discovery-testnet ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2024 9:15am

@erditkurteshiSQA erditkurteshiSQA linked an issue Jan 9, 2024 that may be closed by this pull request
Copy link
Collaborator

@calebjacob calebjacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Highlights a PR's description in the 'Fixes' changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session is lost when signing in with MyNearWallet
3 participants