Removed unnecessary dependency features, changed default features #1143
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I removed the legacy and ABI from default features. I am not sure about the removal of ABI about defaults, but legacy seems like it should be removed, though this will require changing the examples to either use the legacy feature or to use the newer
near_sdk::store
which has a nearly identical interface, but better matches std::collections interfaces.The other part was testing compilation and looking over features used by direct dependencies, where I found a dozen or so unnecessary features and potential optimizations.
The CI/CD tests currently fail with a lot of erros like below, once I know the final decision regarding the legacy feature, I will make updates to the tests according to the decision.