Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit testing feature init #1230

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Conversation

lordshashank
Copy link
Contributor

@lordshashank
Copy link
Contributor Author

@frol , I've done this in creates you stated, again stating that by following #1168 (comment) it was failing on examples/adder thus added that as well. Had two suggestions:-

  • is there any way to get all the crates where this issue could occur?
  • should we add the test stated at near sdk 5.1.0 tests issue #1168 (comment) to all crates so that CI automatically fails in such cases in future?

@frol
Copy link
Collaborator

frol commented Aug 1, 2024

is there any way to get all the crates where this issue could occur?

I don't think so.

should we add the test stated at #1168 (comment) to all crates so that CI automatically fails in such cases in future?

Nope, the existing example tests should be enough.

@lordshashank
Copy link
Contributor Author

@race-of-sloths include this PR please

@race-of-sloths
Copy link

race-of-sloths commented Aug 1, 2024

@lordshashank Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
New Sloth joined the Race! Welcome!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

Your contribution is much appreciated with a final score of 2!
You have received 30 (20 base + 10 weekly bonus) Sloth points for this contribution

Another weekly streak completed, well done @lordshashank! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lordshashank Thanks for working on it!

@race-of-sloths score 2

@race-of-sloths
Copy link

🌟 Score recorded!

@frol, thank you for scoring this pull request in the Race of Sloths!

@frol frol merged commit 1fda82d into near:master Aug 1, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

near sdk 5.1.0 tests issue
3 participants