Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: allow clippy::needless_lifetimes (1.83 more suggestions) #1267

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Nov 28, 2024

after comparing with #1266 the replacement '_ doesn't look all that informative
image

mentioning rust-lang/rust-clippy#13514

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.23%. Comparing base (e0a9b54) to head (642dba7).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1267   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files         102      102           
  Lines       14598    14598           
=======================================
  Hits        11712    11712           
  Misses       2886     2886           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dj8yfo dj8yfo marked this pull request as ready for review November 28, 2024 17:45
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Nov 28, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Nov 28, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@akorchyn 2

Your contribution is much appreciated with a final score of 2!
You have received 69 (20 base + 40 weekly bonus + 15% lifetime bonus) Sloth points for this contribution

@akorchyn received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @dj8yfo! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@akorchyn
Copy link
Collaborator

@race-of-sloths score 2

@dj8yfo dj8yfo merged commit d7c16c8 into near:master Nov 28, 2024
38 of 39 checks passed
@frol frol mentioned this pull request Nov 28, 2024
This was referenced Dec 13, 2024
akorchyn pushed a commit that referenced this pull request Dec 16, 2024
## 🤖 New release
* `near-sdk`: 5.6.0 -> 5.7.0 (✓ API compatible changes)
* `near-sdk-macros`: 5.6.0 -> 5.7.0
* `near-contract-standards`: 5.6.0 -> 5.7.0 (✓ API compatible changes)

<details><summary><i><b>Changelog</b></i></summary><p>

## `near-sdk`
<blockquote>

## [5.7.0](near-sdk-v5.6.0...near-sdk-v5.7.0) - 2024-12-13

### Other

- updates near-* dependencies to 0.28 release (#1272)
- tests for Lazy and moving out of unstable (#1268)
- add a `cargo doc` job (#1269)
- allow clippy::needless_lifetimes (1.83 more suggestions) (#1267)
- examples for Near-related host functions (#1259)
- updates near-workspaces to 0.15 version (#1260)
</blockquote>

## `near-contract-standards`
<blockquote>

## [5.7.0](near-contract-standards-v5.6.0...near-contract-standards-v5.7.0) - 2024-12-13

### Other

- add a `cargo doc` job (#1269)
- allow clippy::needless_lifetimes (1.83 more suggestions) (#1267)
</blockquote>


</p></details>

---
This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).
@frol frol mentioned this pull request Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants