-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: impl details of #[callback_unwrap]
#1319
Open
dj8yfo
wants to merge
8
commits into
near:master
Choose a base branch
from
dj8yfo:impl_details_callback_unwrap
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+83
−16
Open
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
72006ec
resolves bullet#1 in https://github.com/near/near-sdk-rs/issues/1265#…
17deb8c
resolves bullet#2 in https://github.com/near/near-sdk-rs/issues/1265#…
4c3b6c2
resolves bullet#4 in https://github.com/near/near-sdk-rs/issues/1265#…
e5c1126
example: correct a wrong example, suggesting a wrong pattern of usage
ebc93de
`#[callback_unwrap]` impl details added
b28864a
changed referenced anchor as per changes in #1307
40196cb
small amendments
022c9af
resolves https://github.com/near/near-sdk-rs/pull/1319#discussion_r19…
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#[callback_vec]
isn't really compatible with#[callback_unwrap]
to be used in this manner, due to a feature??/bug??, because it revisits the same promise indices, already visited bycallback_unwrap
,so
others
vector in this example containeda
andb
as first elementsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I don't get it. It worked before and now it does not?