Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: derive borsh traits for sys::windows::memory::Protect #158

Closed
wants to merge 1 commit into from

Conversation

dj8yfo
Copy link

@dj8yfo dj8yfo commented Jan 15, 2024

Description

Review

  • Add a short description of the change to the CHANGELOG.md file

@dj8yfo dj8yfo force-pushed the windows_protect_derive_borsh branch 2 times, most recently from 3c1e9aa to f7253d0 Compare January 15, 2024 17:29
@nagisa
Copy link
Collaborator

nagisa commented Jan 15, 2024

How do we end up needing this? Can you please paste the full error? It seems pretty weird to need to encode this as borsh…

@dj8yfo
Copy link
Author

dj8yfo commented Jan 15, 2024

@nagisa, is this weirder than

#[derive(
Serialize, Deserialize, Debug, Copy, Clone, PartialEq, Eq, BorshSerialize, BorshDeserialize,
)]
#[allow(dead_code)]
pub enum Protect {
?
I'll close this now, this was a tmp attempt to work around some cargo check on Windows in near/near-sdk-rs#1130 , but wasmer-singlepass-backend-near appears to explicitly state it wasn't designed for Windows https://github.com/near/wasmer/blob/near-0.x/lib/singlepass-backend/src/lib.rs#L22-L29

@dj8yfo dj8yfo closed this Jan 15, 2024
@nagisa
Copy link
Collaborator

nagisa commented Jan 15, 2024

is this weirder than

Yes, I’m surprised these types implement Borsh ser/de… Either way this is all legacy and dragons and hopefully going away entirely at some point so as long as we can make things work out for y'all without making changes here, that’d be swell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants