NebulaResolutionRulesExtension: override setters to avoid losing include/exclude/optional rules (#148)

Author: rpalcolea

src/main/kotlin/nebula/plugin/resolutionrules/plugin.kt

@@ -203,8 +203,19 @@ abstract class NebulaResolutionRulesService : BuildService<NebulaResolutionRules
 
 open class NebulaResolutionRulesExtension @Inject constructor(private val project: Project) {
     var include = ArrayList<String>()
+        set(value) {
+            field.addAll(value)
+        }
+
     var optional = ArrayList<String>()
+        set(value) {
+            field.addAll(value)
+        }
     var exclude = ArrayList<String>()
+        // Setter should add to the existing array rather than replacing all values
+        set(value) {
+            field.addAll(value)
+        }
 
     fun ruleSet(): RuleSet {
         val service = NebulaResolutionRulesService.registerService(project).get()

src/test/groovy/nebula/plugin/resolutionrules/NebulaResolutionRulesExtensionTest.groovy

@@ -0,0 +1,72 @@
+package nebula.plugin.resolutionrules
+
+import org.gradle.api.Project
+import spock.lang.Specification
+
+class NebulaResolutionRulesExtensionTest extends Specification {
+
+    Project project = Mock(Project)
+
+    def 'can assign values'() {
+        given:
+        def extension = new NebulaResolutionRulesExtension(project)
+
+        when:
+        extension.include = ['something']
+        extension.optional = ['some-rule']
+        extension.exclude = ['foo']
+
+        then:
+        extension.include.contains('something')
+        extension.optional.contains('some-rule')
+        extension.exclude.contains('foo')
+    }
+
+    def 'can assign and append to exclude value'() {
+        given:
+        def extension = new NebulaResolutionRulesExtension(project)
+
+        when:
+        extension.include = ['something']
+        extension.include.add('else')
+
+        extension.exclude = ['foo']
+        extension.exclude.add('bar')
+
+        extension.optional = ['some-rule']
+        extension.optional.add('another-rule')
+
+
+        then:
+        extension.include.contains('something')
+        extension.include.contains('else')
+        extension.exclude.contains('foo')
+        extension.exclude.contains('bar')
+        extension.optional.contains('some-rule')
+        extension.optional.contains('another-rule')
+    }
+
+    def 'can assign and setter does not override existing values'() {
+        given:
+        def extension = new NebulaResolutionRulesExtension(project)
+
+        when:
+
+        extension.include = ['something']
+        extension.include = ['else']
+
+        extension.exclude = ['foo']
+        extension.exclude = ['bar']
+
+        extension.optional = ['some-rule']
+        extension.optional = ['another-rule']
+
+        then:
+        extension.include.contains('something')
+        extension.include.contains('else')
+        extension.exclude.contains('foo')
+        extension.exclude.contains('bar')
+        extension.optional.contains('some-rule')
+        extension.optional.contains('another-rule')
+    }
+}