[HotFix] Ensure cryp4gh keys are loaded on startup. #1663
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbygdell
force-pushed
the
hotfix/c4gh-key-config
branch
2 times, most recently
from
5f9be95 to
507e90c
Compare
pontus
reviewed
May 12, 2025
pontus
reviewed
May 12, 2025
pontus
approved these changes
May 12, 2025
nanjiangshu
reviewed
May 12, 2025
jbygdell
force-pushed
the
hotfix/c4gh-key-config
branch
from
507e90c to
24eae14
Compare
I know, it is in the PR description.. |
jbygdell
force-pushed
the
hotfix/c4gh-key-config
branch
from
24eae14 to
69f7594
Compare
nanjiangshu
approved these changes
May 15, 2025
aaperis
reviewed
May 15, 2025
Comment on lines
+738
to
+743
| func (ts *TestSuite) TestDetectMisingC4GHKeys() { | ||
| viper.Set("c4gh.privateKeys", "") | ||
| privateKeys, err := config.GetC4GHprivateKeys() | ||
| assert.NoError(ts.T(), err) | ||
| assert.Equal(ts.T(), 0, len(privateKeys)) | ||
| } |
There was a problem hiding this comment.
What does this part check? Does it check that config.GetC4GHprivateKeys translates an empty string to an empty array?
I guess to ensure that the fix won't break the code?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s) and PR(s)
This PR closes #1597
This PR closes #1662.
Description
This PR fixes a bug in the code where
IngestandVerifywould happily start even when no crypt4gh keys have been configured.How to test
Remove the
c4gh.privateKeysblock from the config file and runmake sda-s3-upExtra info
Chart tests will fail since the charts are not updated to handle multiple keys yet. (WIP to be completed once this is merged.)