Bugfix in the sda-svc helm chart #1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Waiting for the chart bump to be merged |
jbygdell
force-pushed
the
bugfix/charts
branch
from
ca95534 to
a6211b7
Compare
aaperis
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Seems to work well!
Except for auth, where I get redirected to http://oidc:8080/authorize?.. which cannot be accessed. But maybe that wasn't working before either? In that case I'm ready to approve.
Another thing, not related to this PR, but that would be nice to get fixed, is the three typos of deploy in the README (deplploy-postgres, k3d-deplpoy-sda-posix ad k3d-deplpoy-sda-s3)
This PR doesn't address any of the local test setups, only the deployment issues. |
MalinAhlberg
approved these changes
Feb 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1069
Description
This PR fixes some issues with the sda-svc chart
/as the last character in the OIDC URL. This is to prevent a string concatenation error.How to test
make k3d-create-cluster
make k3d-import-images
make k3d-deploy-dependencies
make k3d-deploy-postgres
make 3d-deploy-rabbitmq
make k3d-deploy-sda-s3