Skip to content

[Snyk] Upgrade axios from 0.18.1 to 0.30.0 #599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nejidevelops
Copy link
Owner

snyk-top-banner

Snyk has created this PR to upgrade axios from 0.18.1 to 0.30.0.

ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.


  • The recommended version is 24 versions ahead of your current version.

  • The recommended version was released a month ago.

Issues fixed by the recommended upgrade:

Issue Score Exploit Maturity
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
472 Proof of Concept
high severity Improper Handling of Extra Parameters
SNYK-JS-FOLLOWREDIRECTS-6141137
472 Proof of Concept
high severity Cross-site Request Forgery (CSRF)
SNYK-JS-AXIOS-6032459
472 Proof of Concept
high severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AXIOS-1579269
472 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
472 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2332181
472 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-6444610
472 Proof of Concept
medium severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2332181
472 Proof of Concept
medium severity Regular Expression Denial of Service (ReDoS)
SNYK-JS-AXIOS-6124857
472 Proof of Concept
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9292519
472 Proof of Concept
medium severity Server-side Request Forgery (SSRF)
SNYK-JS-AXIOS-9403194
472 No Known Exploit
medium severity Server-Side Request Forgery (SSRF)
SNYK-JS-AXIOS-1038255
472 Proof of Concept
low severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2396346
472 No Known Exploit
low severity Information Exposure
SNYK-JS-FOLLOWREDIRECTS-2396346
472 No Known Exploit
Release notes
Package name: axios from axios GitHub release notes

Important

  • Check the changes in this PR to ensure they won't cause issues with your project.
  • This PR was automatically created by Snyk using the credentials of a real user.
  • Max score is 1000. Note that the real score may have changed since the PR was raised.

Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open upgrade PRs.

For more information:

Snyk has created this PR to upgrade axios from 0.18.1 to 0.30.0.

See this package in npm:
axios

See this project in Snyk:
https://app.snyk.io/org/mohammadnewton/project/c20b2f23-22a3-4036-b357-65d6cbe90b67?utm_source=github&utm_medium=referral&page=upgrade-pr
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @nejidevelops, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request upgrades the axios dependency from version 0.18.1 to 0.30.0. This upgrade addresses multiple security vulnerabilities, including issues related to improper handling of extra parameters, cross-site request forgery (CSRF), regular expression denial of service (ReDoS), server-side request forgery (SSRF), and information exposure. The PR updates the package-lock.json and package.json files to reflect the new version and its dependencies.

Highlights

  • Dependency Upgrade: The core change is upgrading the axios dependency from version 0.18.1 to 0.30.0.
  • Security Fixes: This upgrade resolves several high and medium severity security vulnerabilities, as outlined in the PR description.
  • Dependency Updates: The package-lock.json file is updated to include the new version of axios and its transitive dependencies, including follow-redirects, form-data, and proxy-from-env.

Changelog

Click here to see the changelog
  • course-04/exercises/c4-client-master/package-lock.json
    • Upgraded axios from 0.18.1 to 0.30.0 (lines 2014, 2015, 2016).
    • Removed debug and ms dependencies related to the old axios version (lines 2022-2042).
    • Added form-data and proxy-from-env dependencies required by the new axios version (lines 2019, 2020).
    • Added call-bind-apply-helpers dependency (lines 2903-2910).
    • Swapped the order of string-width and string_decoder (lines 3487-3504).
    • Upgraded combined-stream from 1.0.7 to 1.0.8 (lines 3788-3790).
    • Added dunder-proto dependency (lines 4946-4954).
    • Added es-define-property, es-errors, es-object-atoms, and es-set-tostringtag dependencies (lines 5096-5124).
    • Upgraded follow-redirects from 1.7.0 to 1.15.9 (lines 6207-6209, 6246-6248).
    • Upgraded function-bind from 1.1.1 to 1.1.2 (lines 7118-7120, 7144-7146).
    • Added get-intrinsic and get-proto dependencies (lines 7158-7187).
    • Added gopd dependency (lines 7298-7301).
    • Upgraded has-symbols from 1.0.0 to 1.1.0 and added has-tostringtag dependency (lines 7397-7407).
    • Added hasown dependency (lines 7480-7485).
    • Added math-intrinsics dependency (lines 9638-9641).
    • Added proxy-from-env dependency (lines 13128-13131).
    • Upgraded string_decoder from 1.1.1 to 1.2.0 (lines 3487-3504, 7073-7090, 15324-15330).
  • course-04/exercises/c4-client-master/package.json
    • Upgraded axios from 0.18.1 to 0.30.0 (line 6).
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A library's upgrade,
A shield against the dark ReDoS,
Security's embrace.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades the axios dependency from version 0.18.1 to 0.30.0. This upgrade addresses several security vulnerabilities, including high-severity issues like Improper Handling of Extra Parameters, Cross-site Request Forgery (CSRF), and Regular Expression Denial of Service (ReDoS). The pull request also includes updates to the package-lock.json file to reflect the new axios version and its dependencies.

Summary of Findings

  • Security Vulnerabilities: The upgrade resolves multiple security vulnerabilities, including high and medium severity issues. It's crucial to ensure that upgrading axios doesn't introduce any regressions or compatibility issues within the application.
  • Dependency Updates: The package-lock.json file has been updated to reflect the new axios version and its dependencies. It's important to verify that all dependencies are compatible and that the update doesn't introduce any conflicts.

Merge Readiness

Given the security vulnerabilities addressed by this upgrade, it is recommended to merge this pull request after verifying that the application functions correctly with the new axios version. Ensure thorough testing to prevent any regressions or compatibility issues. I am unable to approve the pull request, and that users should have others review and approve this code before merging. Given the high severity vulnerabilities fixed by this PR, I recommend that this pull request not be merged until those are addressed (at a minimum).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants