-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Act should pass proxy build args when building Docker actions #2722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
PR submitted, where |
…-vars nektos#2722 docker build proxy vars
Hi @john-tipper I've faced a similar issue, and I was trying to rely on the Docker client configuration file, instead of passing environement variables: However, I can't understand yet why Docker skips this client configuration files when invoked through Your PR partially solves this problem by explicitely passing the proxy setting to the Docker build environment, but I believe it doesn't solve the proxy issue when running a container ? |
Hi @Wenzel, I believe the reason your client configuration file is being ignored is because Act is using the Docker API, not the Docker client. There are several configuration steps that need to be resolved in order for Act to be able to run behind a proxy:
|
Hi @john-tipper, thanks to your detailed reply, i learned about
The issue was that one of my job was invoking Docker directly, and client is checking for that file to inject the proxy env var into the containers (build or run commands) |
…-vars nektos#2722 docker build proxy vars
Act version
act version 0.2.76
Feature description
Act does not pass any build args to Docker when it builds Docker-based actions. As a result, if Act is run in an enterprise environment where access to the internet is through a proxy, then these actions all break and are unusable, i.e. all third-party docker actions are unusable.
Act should allow the user to optionally pass in proxy variables (HTTP_PROXY, HTTPS_PROXY and NO_PROXY) to the build of Docker actions. This should also include the lowercased versions too.
The text was updated successfully, but these errors were encountered: