Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add completion transformers #4

Conversation

andrey-canon
Copy link
Collaborator

@andrey-canon andrey-canon commented Dec 12, 2024

Description:

Migration pr of multiple changes that were included in the following event-routing backends issue

nelc/event-routing-backends#6
nelc/event-routing-backends#8
nelc/event-routing-backends#10

How to test

  1. Add this setting EVENT_ROUTING_BACKEND_BATCHING_ENABLED = False This doesn't affect the behavior of these changes but allow to test easier
  2. Create a section with a unique sub section and a unique unit
  3. Complete the unit
  4. Check aspects SELECT emission_time, event from xapi.xapi_events_all_parsed where verb_id='http://adlnet.gov/expapi/verbs/completed' ORDER BY emission_time DESC ;

Look for vertical, sequential and chapter records

image

image

image

@andrey-canon andrey-canon force-pushed the redwood-mig/add_completion_transformers branch 14 times, most recently from 7fec075 to 03e298b Compare December 13, 2024 17:05
@andrey-canon andrey-canon force-pushed the redwood-mig/add_completion_transformers branch from 03e298b to d6622c6 Compare December 13, 2024 17:12
Copy link

@johanseto johanseto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM working in my local env.

Screenshot from 2024-12-17 11-57-23

Screencast.from.17-12-24.11.38.08.webm

@andrey-canon andrey-canon merged commit 8199d79 into open-release/redwood.nelp Dec 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants