Move applying failIfMissing to its own function

Author: knutwalker

applications/graph-store-catalog/src/main/java/org/neo4j/gds/applications/graphstorecatalog/DefaultGraphCatalogApplications.java

@@ -548,17 +548,11 @@ public GraphDropNodePropertiesResult dropNodeProperties(
         var graphStoreWithConfig = graphStoreCatalogService.get(CatalogRequest.of(user, databaseId), graphName);
         var graphStore = graphStoreWithConfig.graphStore();
 
-
-        List<String> droppedProperties;
-        if (configuration.failIfMissing()) {
-            graphStoreValidationService.ensureNodePropertiesExist(graphStore, configuration.nodeProperties());
-            droppedProperties = configuration.nodeProperties();
-        } else {
-            droppedProperties = graphStoreValidationService.filterExistingNodeProperties(
-                graphStore,
-                configuration.nodeProperties()
-            );
-        }
+        var droppedProperties = gatherDroppedProperties(
+            graphStore,
+            configuration.nodeProperties(),
+            configuration.failIfMissing()
+        );
 
         var numberOfPropertiesRemoved = dropNodePropertiesApplication.compute(
             taskRegistryFactory,
@@ -574,6 +568,19 @@ public GraphDropNodePropertiesResult dropNodeProperties(
         );
     }
 
+    private List<String> gatherDroppedProperties(
+        GraphStore graphStore,
+        List<String> nodeProperties,
+        boolean failIfMissing
+    ) {
+        if (failIfMissing) {
+            graphStoreValidationService.ensureNodePropertiesExist(graphStore, nodeProperties);
+            return nodeProperties;
+        } else {
+            return graphStoreValidationService.filterExistingNodeProperties(graphStore, nodeProperties);
+        }
+    }
+
     @Override
     public GraphDropRelationshipResult dropRelationships(
         User user,