Skip to content

Commit 99bf50e

Browse files
authored
Fix/datetime warning (#202)
* Fix deprecation warning (utcnow) * Mypy
1 parent cb96815 commit 99bf50e

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

src/neo4j_graphrag/experimental/pipeline/pipeline.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@
1515
from __future__ import annotations
1616

1717
import asyncio
18+
import datetime
1819
import enum
1920
import logging
2021
import uuid
2122
import warnings
2223
from collections import defaultdict
23-
from datetime import datetime
2424
from timeit import default_timer
2525
from typing import Any, AsyncGenerator, Optional
2626

@@ -61,7 +61,9 @@ class RunStatus(enum.Enum):
6161
class RunResult(BaseModel):
6262
status: RunStatus = RunStatus.DONE
6363
result: Optional[DataModel] = None
64-
timestamp: datetime = Field(default_factory=datetime.utcnow)
64+
timestamp: datetime.datetime = Field(
65+
default_factory=lambda: datetime.datetime.now(datetime.timezone.utc)
66+
)
6567

6668

6769
class TaskPipelineNode(PipelineNode):

tests/unit/experimental/pipeline/test_pipeline.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,14 @@
1616

1717
import asyncio
1818
import tempfile
19+
from typing import Sized
1920
from unittest import mock
2021
from unittest.mock import AsyncMock, call, patch
2122

2223
import pytest
2324
from neo4j_graphrag.experimental.pipeline import Component, Pipeline
2425
from neo4j_graphrag.experimental.pipeline.exceptions import PipelineDefinitionError
26+
from neo4j_graphrag.experimental.pipeline.pipeline import RunResult
2527

2628
from .components import (
2729
ComponentAdd,
@@ -404,3 +406,8 @@ def test_pipeline_draw_missing_pygraphviz_dep() -> None:
404406
t = tempfile.NamedTemporaryFile()
405407
with pytest.raises(ImportError):
406408
pipe.draw(t.name)
409+
410+
411+
def test_run_result_no_warning(recwarn: Sized) -> None:
412+
RunResult()
413+
assert len(recwarn) == 0

0 commit comments

Comments
 (0)