Skip to content

Fixes for graph pruning #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Fixes for graph pruning #359

wants to merge 7 commits into from

Conversation

stellasia
Copy link
Contributor

@stellasia stellasia commented Jun 12, 2025 •
edited
Loading

Description

Note: tests are not updated yet

  • New paramters (additional_node_types...) were not propagated properly in the SimpleKGBuilderConfig object
  • Lexical graph was pruned :''''(
  • Some components were missing the lexical graph input
  • Make deprecated parameters even more explicit in the documention

Type of Change

  • New feature
  • Bug fix
  • Breaking change
  • Documentation update
  • Project configuration change

Complexity

Note

Please provide an estimated complexity of this PR of either Low, Medium or High

Complexity:

How Has This Been Tested?

  • Unit tests
  • E2E tests
  • Manual tests

Checklist

The following requirements should have been met (depending on the changes in the branch):

  • Documentation has been updated
  • Unit tests have been updated
  • E2E tests have been updated
  • Examples have been updated
  • New files have copyright header
  • CLA (https://neo4j.com/developer/cla/) has been signed
  • CHANGELOG.md updated if appropriate

@stellasia stellasia marked this pull request as ready for review June 13, 2025 13:54
@stellasia stellasia requested a review from a team as a code owner June 13, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stellasia