develop-acp99 #30
Open
develop-acp99 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
contracts/validator-manager/Native721TokenStakingManager.sol
Dismissed
Show dismissed
Hide dismissed
* initilialiser checks and events * add complete delegator removal if validator has ended * add tests for double delegation and stake and nft delegation by same delegator * fix tests and add nft event * add locked nfts to event
* add validator removal admin * nit: fix extra space
zjesko
force-pushed
the
develop-acp99
branch
2 times, most recently
from
3f489d9 to
1c3128c
Compare
zjesko
force-pushed
the
develop-acp99
branch
from
1c3128c to
bc5710f
Compare
Comment on lines
+716
to
+731
| function _calculateEffectiveWeight( | ||
| uint256 weight, | ||
| uint64 currentUptime, | ||
| uint64 previousUptime | ||
| ) internal view returns (uint256) { | ||
| if(previousUptime > currentUptime || currentUptime == 0) { | ||
| return 0; | ||
| } | ||
|
|
||
| // Return full weight if uptime is above threshold | ||
| if((currentUptime - previousUptime) * 100 / _getStakingManagerStorage()._epochDuration > UPTIME_REWARDS_THRESHOLD_PERCENTAGE) { | ||
| return weight; | ||
| } | ||
| // Calculate effective weight based on both weight and time period | ||
| return (weight * (currentUptime - previousUptime)) / _getStakingManagerStorage()._epochDuration; | ||
| } |
Check warning
Code scanning / Slither
Dangerous strict equalities Medium
Comment on lines
+716
to
+731
| function _calculateEffectiveWeight( | ||
| uint256 weight, | ||
| uint64 currentUptime, | ||
| uint64 previousUptime | ||
| ) internal view returns (uint256) { | ||
| if(previousUptime > currentUptime || currentUptime == 0) { | ||
| return 0; | ||
| } | ||
|
|
||
| // Return full weight if uptime is above threshold | ||
| if((currentUptime - previousUptime) * 100 / _getStakingManagerStorage()._epochDuration > UPTIME_REWARDS_THRESHOLD_PERCENTAGE) { | ||
| return weight; | ||
| } | ||
| // Calculate effective weight based on both weight and time period | ||
| return (weight * (currentUptime - previousUptime)) / _getStakingManagerStorage()._epochDuration; | ||
| } |
Check notice
Code scanning / Slither
Block timestamp Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why this should be merged
How this works
How this was tested
How is this documented