BUGFIX: Standalone Core - move AuthProviderFactoryInterface to correct packgage
#5547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect packgage Neos\ContentRepository\Core MUST NOT have a dependency to Neos\ContentRepositoryRegistry this was a hickup because at one point the cr factory did not need an AuthProviderFactoryInterface but the AuthProvider directly. see b4e0c78
reintroduced the factory at its old position and converts it to a new instance via DecoratingLegacyAuthProviderFactory note that a manual standalone core integration via ContentRepositoryFactory will not be treated b/c because that is impossible without having the registry package installed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Neos\ContentRepository\Core MUST NOT have a dependency to Neos\ContentRepositoryRegistry
this was a hickup because at one point the cr factory did not need an AuthProviderFactoryInterface but the AuthProvider directly.
see b4e0c78
Upgrade instructions
Review instructions
Checklist
FEATURE|TASK|BUGFIX!!!and have upgrade-instructions