Skip to content

BUGFIX: Standalone subscription store via Neos.ContentRepository.Dbal #5552

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: 9.0
Choose a base branch
from

Conversation

mhsdesign
Copy link
Member

@mhsdesign mhsdesign commented May 2, 2025

This pr is a non breaking architecture fix pr to be released with the next patch 9.0.x release.
It introduces a new package which will be installed automatically when updating to that patch.
Few internal classes were moved to that package, most importantly the SubscriptionStore implementation allowing custom standalone cr integration to instantiate that class and boot a cr without requiring the cr registry which requires flow.
The SubscriptionStoreFactory and SubscriptionStoreFactoryInterface have not been moved to that package as they are correctly part of the CR Registry. The core just excepts an SubscriptionStoreInterface instance no factory.

Upgrade instructions

Review instructions

Checklist

  • Code follows the PSR-2 coding style
  • Tests have been created, run and adjusted as needed
  • The PR is created against the lowest maintained branch
  • Reviewer - PR Title is brief but complete and starts with FEATURE|TASK|BUGFIX
  • Reviewer - The first section explains the change briefly for change-logs
  • Reviewer - Breaking Changes are marked with !!! and have upgrade-instructions

@@ -0,0 +1,21 @@
{
"name": "neos/contentrepository-dbal",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so we group now here both the DbalSchemaDiff as well as the subscription store implementation. That makes sense because the subscription store needs the diff... it a little weird that now because the neos/contentgraph-doctrinedbaladapter depends on the diff and thus brings the subscription engine and the dbal doctrine store.
On the other hand this seems like a good cut. A postgres graph can now still use the common dbal subscription engine without fetching the doctrinedbaladapter into the boat ... so 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant