BUG: Cast FileProxy sizes to integer (#96)

nerdgeschoss · Jul 23, 2024 · e6217da · e6217da
1 parent 2f41a1e
commit e6217da
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/lib/shimmer/utils/file_proxy.rb b/lib/shimmer/utils/file_proxy.rb
@@ -39,7 +39,7 @@ def message_verifier
 
     def initialize(blob_id:, width: nil, height: nil)
       @blob_id = blob_id
-      @resize = [width, height] if width || height
+      @resize = [width&.to_i, height&.to_i] if width || height
     end
 
     def path

diff --git a/spec/utils/shimmer/file_proxy_spec.rb b/spec/utils/shimmer/file_proxy_spec.rb
@@ -43,6 +43,14 @@
       expect(dimensions(variant.processed.image.blob)).to eq({width: 290, height: 100})
     end
 
+    it "works if passing width or height as string" do
+      proxy = Shimmer::FileProxy.new(blob_id: blob.id, width: "290", height: "100")
+      id = proxy.send(:id)
+      variant = Shimmer::FileProxy.restore(id).variant
+
+      expect(dimensions(variant.processed.image.blob)).to eq({width: 290, height: 100})
+    end
+
     it "works if not resizing" do
       proxy = Shimmer::FileProxy.new(blob_id: blob.id)
       id = proxy.send(:id)