Skip to content

DRAFT: 136 fix branch reversion #281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

DRAFT: 136 fix branch reversion #281

wants to merge 3 commits into from

Conversation

arthanson
Copy link
Contributor

@arthanson arthanson commented Jun 13, 2025

Fixes: #136

Note: This requires the NetBox change netbox-community/netbox#19680 to work correctly.

This was caused by several issues:

  1. In NetBox the ordering of ChangeLog items when there were GenericRelations between them was out-of-order. This is fixed in the NetBox PR above.
  2. Following this - the deserialize_object was using self.prechange_data, but this was picking up internal fields like _path on cabled objects, changed to use self.prechange_data_clean to remove these fields.
  3. Also - the clean method in Cable uses the GenericForeign key reference, the deserializer sets the object_id and content_type but the actual content_object was None. This goes through and fixes these back up.

@arthanson arthanson changed the title 136 fix branch reversion DRAFT: 136 fix branch reversion Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to revert a branch that removed a device.
1 participant