Skip to content

Commit f5d9790

Browse files
committed
LatteFactory: $control is passed to create() (BC break)
1 parent c4f97cb commit f5d9790

File tree

4 files changed

+5
-21
lines changed

4 files changed

+5
-21
lines changed

src/Bridges/ApplicationDI/LatteExtension.php

+3-2
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,9 @@ public function loadConfiguration(): void
6161
->addSetup('setStrictTypes', [$config->strictTypes])
6262
->addSetup('setStrictParsing', [$config->strictParsing])
6363
->addSetup('enablePhpLinter', [$config->phpLinter])
64-
->addSetup('setLocale', [$config->locale])
65-
->addSetup('?', [$builder::literal('func_num_args() && $service->addExtension(new Nette\Bridges\ApplicationLatte\UIExtension(func_get_arg(0)))')]);
64+
->addSetup('setLocale', [$config->locale]);
65+
66+
$this->addExtension(new Statement(ApplicationLatte\UIExtension::class, [$builder::literal('$control')]));
6667

6768
if ($builder->getByType(Nette\Caching\Storage::class)) {
6869
$this->addExtension(new Statement(Nette\Bridges\CacheLatte\CacheExtension::class));

src/Bridges/ApplicationLatte/LatteFactory.php

+2-1
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,12 @@
1010
namespace Nette\Bridges\ApplicationLatte;
1111

1212
use Latte;
13+
use Nette\Application\UI\Control;
1314

1415

1516
interface LatteFactory
1617
{
17-
function create(/*?Control $control = null*/): Latte\Engine;
18+
function create(?Control $control = null): Latte\Engine;
1819
}
1920

2021

src/Bridges/ApplicationLatte/TemplateFactory.php

-4
Original file line numberDiff line numberDiff line change
@@ -48,10 +48,6 @@ public function createTemplate(?UI\Control $control = null, ?string $class = nul
4848
$template = new $class($latte);
4949
$presenter = $control?->getPresenterIfExists();
5050

51-
if (!Nette\Utils\Arrays::some($latte->getExtensions(), fn($e) => $e instanceof UIExtension)) {
52-
$latte->addExtension(new UIExtension($control));
53-
}
54-
5551
// default parameters
5652
$baseUrl = $this->httpRequest
5753
? rtrim($this->httpRequest->getUrl()->withoutUserInfo()->getBaseUrl(), '/')

tests/Bridges.DI/LatteExtension.basic.phpt

-14
Original file line numberDiff line numberDiff line change
@@ -59,20 +59,6 @@ Assert::type(Nette\Bridges\ApplicationLatte\LatteFactory::class, $container->get
5959
$latte = $container->getService('nette.latteFactory')->create();
6060
$extensions = Assert::with($latte, fn() => $this->extensions);
6161

62-
Assert::equal([
63-
new Latte\Essential\CoreExtension,
64-
new Latte\Sandbox\SandboxExtension,
65-
new Nette\Bridges\FormsLatte\FormsExtension,
66-
new MyExtension,
67-
new MyExtension(1),
68-
new MyExtension(2),
69-
new MyExtension,
70-
], $extensions);
71-
72-
// UIExtension is added
73-
$latte = $container->getService('nette.latteFactory')->create(null);
74-
$extensions = Assert::with($latte, fn() => $this->extensions);
75-
7662
Assert::equal([
7763
new Latte\Essential\CoreExtension,
7864
new Latte\Sandbox\SandboxExtension,

0 commit comments

Comments
 (0)