Feat: whitelist LPs #NTRN-442 #799
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 9, 2025
NeverHappened
requested changes
Feb 24, 2025
x/dex/types/params.go
Outdated
| @@ -18,6 +19,8 @@ var ( | |||
| DefaultMaxJITsPerBlock uint64 = 25 | |||
| KeyGoodTilPurgeAllowance = []byte("PurgeAllowance") | |||
| DefaultGoodTilPurgeAllowance uint64 = 540_000 | |||
| KeyWhitelistedLPs = []byte("PurgeAllowance") | |||
x/dex/types/params.go
Outdated
| for _, addr := range whitelistedLPs { | ||
| _, err := sdk.AccAddressFromBech32(addr) | ||
| if err != nil { | ||
| return fmt.Errorf("invalid Reserve address (%s): %w, ", addr, err) |
| @@ -18,6 +19,8 @@ var ( | |||
| DefaultMaxJITsPerBlock uint64 = 25 | |||
| KeyGoodTilPurgeAllowance = []byte("PurgeAllowance") | |||
| DefaultGoodTilPurgeAllowance uint64 = 540_000 | |||
| KeyWhitelistedLPs = []byte("PurgeAllowance") | |||
| DefaultKeyWhitelistedLPs []string | |||
There was a problem hiding this comment.
maybe assign an empty array to default to be more clear here?
There was a problem hiding this comment.
linter does not like assigning an empty array
x/dex/keeper/deposit.go
Outdated
| if err := k.ValidateFee(ctx, fee); err != nil { | ||
| return nil, nil, math.ZeroInt(), math.ZeroInt(), nil, nil, nil, err | ||
| // Enforce deposits only at valid fee tiers. This does not apply to whitelistedLPs | ||
| if !k.IsWhitelistedLP(ctx, callerAddr) { |
There was a problem hiding this comment.
can we move this check out of the loop? A small optimization.
pr0n00gler
approved these changes
Feb 25, 2025
@NicholasDotSol do we have contract addresses now? Or do we wanna just use chainmanager dao after upgrade? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new dex param for whitelisted LPs. These LPs are able to deposit outside the allowed
fee_tiers. This is required for super vaults so they can use special fee_tiers that do no clash with other users.RELATED PRs
neutron-org/neutron-std#9
neutron-org/neutron-dao#117
neutron-org/neutronjs#11
neutron-org/neutron-integration-tests#372
neutron-org/neutronjsplus#73