-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EnableReloading attribute on class, but CanReload is still false #86
Comments
typeof(UnityModManager.ModEntry).GetProperty("CanReload").SetValue(entry, true, null); works 🤡 |
Strange, it usually always worked. Because the method and the property are in the same object. |
Weird, looks like reloading also doesn't load the new assembly properly, still getting a log message I removed even after wiping all the DLLs (including the cached one) and hitting reload. Looks like reload is just generally too unreliable, just going to be restarting the game as usual then |
Yes it is, with each new unity version, the restart becomes more and more difficult. |
I discovered over a year later by looking through UMM's code that you must declare a minimum manager version of at least 0.13. This is not documented anywhere, but adding this to the info.json makes it work "ManagerVersion": "0.23.5.0", This issue can be closed once the wiki says that you need this in order to make reloading work. |
The entire source file is this:
It prints
false
. I opened the DLL in dnSpy and it looks like the annotation is still there. What gives? I would have expected this check to pass:unity-mod-manager/UnityModManager/ModManager.cs
Lines 600 to 602 in c525b6f
The reload button simply does not show up in the ctrl+f10 menu.
The text was updated successfully, but these errors were encountered: