Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make package ESM by default #696

Merged
merged 1 commit into from
Jan 22, 2024
Merged

Make package ESM by default #696

merged 1 commit into from
Jan 22, 2024

Conversation

susnux
Copy link
Collaborator

@susnux susnux commented Jan 22, 2024

No description provided.

@susnux
fix: Make package ESM by default
1f082f2 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added the 3. to review Waiting for reviews label Jan 22, 2024
@susnux susnux requested review from skjnldsv, Pytal and ShGKme January 22, 2024 22:24
ShGKme
ShGKme approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ShGKme ShGKme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we consider it a breaking change in @nextcloud/vue, should it be a breaking change here as well?

@susnux
Copy link
Collaborator Author

susnux commented Jan 22, 2024

Funny we did it as a minor change on various other libraries 😅
But yes probably doing it as a breaking then

@susnux susnux merged commit 3747940 into main Jan 22, 2024
10 checks passed
@susnux susnux deleted the chore/make-package-esm branch January 22, 2024 23:03
@susnux susnux mentioned this pull request Mar 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@ShGKme ShGKme ShGKme approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@susnux @Pytal @ShGKme