Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update timezones data #34

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update timezones data #34

wants to merge 1 commit into from

Conversation

github-actions[bot]
Copy link

Auto-generated update of timezones data

ChristophWurst
ChristophWurst reviewed Nov 13, 2024
View reviewed changes
resources/timezones/zones.json
]
},
"Asia/Almaty": {
"ics": [
"BEGIN:STANDARD\r\nTZOFFSETFROM:+0500\r\nTZOFFSETTO:+0500\r\nTZNAME:+05\r\nDTSTART:19700101T000000\r\nEND:STANDARD"
"BEGIN:STANDARD\r\nTZOFFSETFROM:+0500\r\nTZOFFSETTO:+0500\r\nTZNAME:%z\r\nDTSTART:19700101T000000\r\nEND:STANDARD"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

%z is suspicious

st3iny
st3iny requested changes Nov 13, 2024
View reviewed changes
Copy link
Collaborator

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have a look at the TZNAME changes. There seems to be something wrong.

resources/timezones/zones.json
"BEGIN:STANDARD\r\nTZOFFSETFROM:+0100\r\nTZOFFSETTO:+0100\r\nTZNAME:+01\r\nDTSTART:19700101T000000\r\nEND:STANDARD"
"BEGIN:STANDARD\r\nTZOFFSETFROM:+0100\r\nTZOFFSETTO:+0100\r\nTZNAME:%z\r\nDTSTART:19700101T000000\r\nEND:STANDARD"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ain't looking right.

Copy link
Collaborator

@st3iny st3iny Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But even before, +01 doesn't seem right too. It should be a string like EST.

Ref https://www.kanzaki.com/docs/ical/tzname.html

@st3iny st3iny self-assigned this Nov 13, 2024
@st3iny @github-actions
fix: update timezones data
1e54ef9 
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot force-pushed the automated/noid/update-timezones-data branch from 763d637 to 1e54ef9 Compare January 1, 2025 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst left review comments

@st3iny st3iny st3iny requested changes

@GretaD GretaD Awaiting requested review from GretaD GretaD is a code owner

Requested changes must be addressed to merge this pull request.

Assignees

@st3iny st3iny

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristophWurst @st3iny