Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing public calendar initial state #5714

Merged
merged 1 commit into from
Jan 24, 2024

Conversation

st3iny
Copy link
Member

@st3iny st3iny commented Jan 24, 2024

The public view of calendars is currently broken. It loads indefinitely because some initial state is missing and breaking the main Calendar view.

Only main seems to be affected.

Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
@st3iny st3iny added this to the v4.7.0 milestone Jan 24, 2024
@st3iny st3iny self-assigned this Jan 24, 2024
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (e6e8c2a) 24.41% compared to head (c9398b7) 24.41%.
Report is 14 commits behind head on main.

Files Patch % Lines
src/views/Calendar.vue 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #5714   +/-   ##
=========================================
  Coverage     24.41%   24.41%           
  Complexity      418      418           
=========================================
  Files           243      243           
  Lines         10874    10874           
  Branches       1790     1790           
=========================================
  Hits           2655     2655           
  Misses         8219     8219           
Flag Coverage Δ
javascript 15.50% <0.00%> (ø)
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@st3iny st3iny merged commit ba77dc2 into main Jan 24, 2024
36 of 37 checks passed
@st3iny st3iny deleted the fix/public-calendars-initial-state branch January 24, 2024 12:50
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug Feature: Public sharing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants