Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(appointments): round up timeslots to next pretty time #5747

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

miaulalala
Copy link
Contributor

No description provided.

@miaulalala miaulalala added 3. to review Waiting for reviews bug labels Feb 8, 2024
@miaulalala miaulalala added this to the v4.7.0 milestone Feb 8, 2024
@miaulalala miaulalala self-assigned this Feb 8, 2024
@miaulalala
Copy link
Contributor Author

/backport to stable4.6

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 8, 2024
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (566265c) 24.49% compared to head (37b2047) 24.50%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/views/EditSidebar.vue 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #5747      +/-   ##
============================================
+ Coverage     24.49%   24.50%   +0.01%     
  Complexity      423      423              
============================================
  Files           243      243              
  Lines         10938    10944       +6     
  Branches       1797     1798       +1     
============================================
+ Hits           2679     2682       +3     
- Misses         8259     8262       +3     
Flag Coverage Δ
javascript 15.43% <0.00%> (-0.01%) ⬇️
php 61.97% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works as I would expect it to work.

Unit test failures seem to be related though.

@miaulalala miaulalala force-pushed the fix/5597/add-increments-for-pretty-times branch from 0749680 to 7d6ffb3 Compare February 14, 2024 10:49
…kings

Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala enabled auto-merge February 14, 2024 13:09
@miaulalala miaulalala force-pushed the fix/5597/add-increments-for-pretty-times branch from 7d6ffb3 to 37b2047 Compare February 14, 2024 13:09
@miaulalala miaulalala changed the title fix(appointments): allow 5 minute increments for rounding in slot bookings fix(appointments): round up timeslots to next pretty time Feb 14, 2024
@miaulalala miaulalala disabled auto-merge February 14, 2024 13:10
@miaulalala miaulalala enabled auto-merge February 14, 2024 13:10
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 14, 2024
@miaulalala miaulalala merged commit f2b7d3b into main Feb 14, 2024
36 of 37 checks passed
@miaulalala miaulalala deleted the fix/5597/add-increments-for-pretty-times branch February 14, 2024 13:50
@backportbot backportbot bot removed the backport-request A backport was requested for this pull request label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
Development

Successfully merging this pull request may close these issues.

"Could not book the appointment. Please try again later or contact the organizer."
3 participants