Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(appointments): add date to booking detail view #5748

Merged
merged 1 commit into from
Feb 8, 2024
Merged

fix(appointments): add date to booking detail view #5748

merged 1 commit into from
Feb 8, 2024

Conversation

miaulalala
Copy link
Contributor

Before:

image

After:

image

@miaulalala miaulalala added this to the v4.7.0 milestone Feb 8, 2024
@miaulalala miaulalala self-assigned this Feb 8, 2024
@miaulalala miaulalala linked an issue Feb 8, 2024 that may be closed by this pull request
Date missing on appointments booking page #5745
Closed
@codecov Codecov
Copy link

codecov bot commented Feb 8, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cb62f5d) 24.35% compared to head (eeacfa6) 24.34%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/utils/localeTime.js 0.00% 2 Missing ⚠️
src/components/Appointments/AppointmentDetails.vue 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #5748      +/-   ##
============================================
- Coverage     24.35%   24.34%   -0.01%     
  Complexity      418      418              
============================================
  Files           243      243              
  Lines         10901    10905       +4     
  Branches       1795     1795              
============================================
  Hits           2655     2655              
- Misses         8246     8250       +4
Flag Coverage Δ
javascript 15.44% <0.00%> (-0.01%) ⬇️
php 61.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala changed the title enh(appointments): add date to booking detail view fix(appointments): add date to booking detail view Feb 8, 2024
@miaulalala
fix(appointments): add date to booking detail view
eeacfa6 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@miaulalala miaulalala force-pushed the enh/5745/add-booking-date branch from 4c91184 to eeacfa6 Compare February 8, 2024 16:24
@miaulalala
Copy link
Contributor Author

/backport to stable4.6

@backportbot backportbot bot added the backport-request A backport was requested for this pull request label Feb 8, 2024
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug and removed backport-request A backport was requested for this pull request labels Feb 8, 2024
@miaulalala
Copy link
Contributor Author

Codecov is having a wobble

@ChristophWurst
Copy link
Member

The warnings are legit. The new code is not tested so the coverage drops

@miaulalala miaulalala merged commit cf2843b into main Feb 8, 2024
35 of 37 checks passed
@miaulalala miaulalala deleted the enh/5745/add-booking-date branch February 8, 2024 17:36
@backportbot backportbot bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@st3iny st3iny Awaiting requested review from st3iny st3iny is a code owner

Assignees

@miaulalala miaulalala

Labels
3. to review Waiting for reviews bug enhancement New feature request Feature: Appointments
Projects
None yet
Milestone
v4.7.0
Development

Successfully merging this pull request may close these issues.

Date missing on appointments booking page
2 participants
@miaulalala @ChristophWurst